DescriptionRevert of SegmentedString::push() should always push a char in front (patchset #2 id:20001 of https://codereview.chromium.org/1308573006/ )
Reason for revert:
HTMLEntityParserTest.ConsumeHTMLEntityIncomplete fails on two Win bots
The newly added test is failing on WebKit Win7 (dbg) and WebKit Win Oilpan
(dbg) with the following message:
[ RUN ] HTMLEntityParserTest.ConsumeHTMLEntityIncomplete
ASSERTION FAILED: !notEnoughCharacters
Sorry for the revert! Full output @ http://goo.gl/tnYH67
Original issue's description:
> SegmentedString::push() should always push a char in front
>
> Before this CL, SegmentedString::push() had an exotic behavior, where
> two consecutive push would swap its order.
>
> This CL changes the push() implementation so that it would always push
> the new char in front of the SegmentedString.
> This CL also updates the HTMLEntityParser code which relied on the behavior.
>
> BUG=None
> TEST={SegmentedStringTest,HTMLEntityParserTest}.*
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201294
TBR=tasak@google.com,tzik@chromium.org,tkent@chromium.org,yosin@chromium.org,kouhei@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201318
Patch Set 1 #
Created: 5 years, 3 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|