Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1311043004: Revert of SegmentedString::push() should always push a char in front (Closed)

Created:
5 years, 3 months ago by Peter Beverloo
Modified:
5 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Revert of SegmentedString::push() should always push a char in front (patchset #2 id:20001 of https://codereview.chromium.org/1308573006/ ) Reason for revert: HTMLEntityParserTest.ConsumeHTMLEntityIncomplete fails on two Win bots The newly added test is failing on WebKit Win7 (dbg) and WebKit Win Oilpan (dbg) with the following message: [ RUN ] HTMLEntityParserTest.ConsumeHTMLEntityIncomplete ASSERTION FAILED: !notEnoughCharacters Sorry for the revert! Full output @ http://goo.gl/tnYH67 Original issue's description: > SegmentedString::push() should always push a char in front > > Before this CL, SegmentedString::push() had an exotic behavior, where > two consecutive push would swap its order. > > This CL changes the push() implementation so that it would always push > the new char in front of the SegmentedString. > This CL also updates the HTMLEntityParser code which relied on the behavior. > > BUG=None > TEST={SegmentedStringTest,HTMLEntityParserTest}.* > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201294 TBR=tasak@google.com,tzik@chromium.org,tkent@chromium.org,yosin@chromium.org,kouhei@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -45 lines) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLEntityParser.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLEntityParser.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
D Source/core/html/parser/HTMLEntityParserTest.cpp View 1 chunk +0 lines, -27 lines 0 comments Download
M Source/platform/text/SegmentedString.h View 1 chunk +3 lines, -5 lines 0 comments Download
M Source/platform/text/SegmentedStringTest.cpp View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Peter Beverloo
Created Revert of SegmentedString::push() should always push a char in front
5 years, 3 months ago (2015-08-27 15:33:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311043004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311043004/1
5 years, 3 months ago (2015-08-27 15:33:31 UTC) #2
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 15:33:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201318

Powered by Google App Engine
This is Rietveld 408576698