Update mojo sdk to rev c02a28868825edfa57ab77947b8cb15e741c5598

Update mojo sdk to rev c02a28868825edfa57ab77947b8cb15e741c5598

Re-land number two. Now with cherry-picked android test fix.

BUG=None
TBR=jam@chromium.org,ben@chromium.org
TBR=mfoltz@chromium.org
TBR=mek@chromium.org
TBR=xhwang@chromium.org
TBR=shess@chromium.org

Committed: https://crrev.com/b6a14b7a0263778a0f04a0c6999d6737f5ee2a0a
Cr-Commit-Position: refs/heads/master@{#345106}

[Ken Rockot(use gerrit already), 2015-08-24 16:45:31]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2015-08-24 16:45:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311043003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311043003/1

[commit-bot: I haz the power, 2015-08-24 17:24:29]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-24 17:25:07]

Patchset 1 (id:??) landed as
https://crrev.com/b6a14b7a0263778a0f04a0c6999d6737f5ee2a0a
Cr-Commit-Position: refs/heads/master@{#345106}

[hans, 2015-08-24 20:44:13]

hans@chromium.org changed reviewers:
+ hans@chromium.org

[hans, 2015-08-24 20:44:14]

https://codereview.chromium.org/1311043003/diff/1/third_party/mojo/src/mojo/e...
File third_party/mojo/src/mojo/edk/system/mutex.h (right):

https://codereview.chromium.org/1311043003/diff/1/third_party/mojo/src/mojo/e...
third_party/mojo/src/mojo/edk/system/mutex.h:26: class MOJO_SYSTEM_IMPL_EXPORT
MOJO_LOCKABLE Mutex {
This is failing to compile with Clang on Windows:

FAILED: ninja -t msvc -e environment.x86 --
"..\..\third_party/llvm-build/Release+Asserts/bin/clang-cl" -m32 /nologo
/showIncludes /FC
@obj\third_party\mojo\src\mojo\edk\embedder\mojo_system_impl.entrypoints.obj.rsp
/c ..\..\third_party\mojo\src\mojo\edk\embedder\entrypoints.cc
/Foobj\third_party\mojo\src\mojo\edk\embedder\mojo_system_impl.entrypoints.obj
/Fdobj\third_party\mojo\mojo_system_impl.cc.pdb 
In file included from
..\..\third_party\mojo\src\mojo\edk\embedder\entrypoints.cc:6:
In file included from ..\..\third_party\mojo\src\mojo/edk/system/core.h:16:
..\..\third_party\mojo\src\mojo/edk/system/mutex.h(26,1) :  error: declaration
of anonymous class must be a definition
class MOJO_SYSTEM_IMPL_EXPORT MOJO_LOCKABLE Mutex {
^
..\..\third_party\mojo\src\mojo/edk/system/mutex.h(26,1) :  error: declaration
does not declare anything [-Werror,-Wmissing-declarations]
class MOJO_SYSTEM_IMPL_EXPORT MOJO_LOCKABLE Mutex {
^
..\..\third_party\mojo\src\mojo/edk/system/mutex.h(76,1) :  error: declaration
of anonymous class must be a definition
class MOJO_SYSTEM_IMPL_EXPORT MOJO_SCOPED_LOCKABLE MutexLocker {
^
..\..\third_party\mojo\src\mojo/edk/system/mutex.h(76,1) :  error: declaration
does not declare anything [-Werror,-Wmissing-declarations]
class MOJO_SYSTEM_IMPL_EXPORT MOJO_SCOPED_LOCKABLE MutexLocker {
^

... and more errors further on as Mutex isn't recognized as a type.


The error message isn't so great, but what's happening is that after macro
expansion, we have:

  class __declspec(dllexport) __attribute__((lockable)) Mutex { };

Mixing declspec and GNU attributes is slightly sketchy territory, but Clang will
actually handle this if they're in the other order. I'll have a look and see
what it would take to fix this or if we'll need to revert.

(Clang bug for handling this better:
https://llvm.org/bugs/show_bug.cgi?id=24559)

https://codereview.chromium.org/1311043003/diff/1/third_party/mojo/src/mojo/p...
File third_party/mojo/src/mojo/public/cpp/bindings/lib/map_data_internal.h
(right):

https://codereview.chromium.org/1311043003/diff/1/third_party/mojo/src/mojo/p...
third_party/mojo/src/mojo/public/cpp/bindings/lib/map_data_internal.h:33: }  //
namespace
This is essentially reverting https://codereview.chromium.org/1279133003/,
causing errors:
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/2806/step...

That's now been fixed by re-landing ttps://codereview.chromium.org/1279133003/,
so we're good here :-)

[brucedawson, 2015-08-31 17:11:07]

This change deletes
third_party\mojo\src\mojo\public\cpp\bindings\interface_impl.h but that file is
still listed in mojo_public.gyp. This is a non-fatal problem but it should be
corrected to avoid future confusion.

[brucedawson, 2015-09-08 17:35:19]

brucedawson@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brucedawson, 2015-09-08 17:35:20]

https://codereview.chromium.org/1311043003/diff/1/third_party/mojo/mojo_publi...
File third_party/mojo/mojo_public.gyp (right):

https://codereview.chromium.org/1311043003/diff/1/third_party/mojo/mojo_publi...
third_party/mojo/mojo_public.gyp:107:
'src/mojo/public/cpp/bindings/interface_impl.h',
interface_impl.h was deleted by this change so this line should be deleted as
well. Currently we have a dangling reference. This isn't too bad, but it can be
confusing.