Issue 131103020: Fix ejecting if the element is not selected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131103020: Fix ejecting if the element is not selected. (Closed)

Created:
6 years, 10 months ago by mtomasz

Modified:
6 years, 10 months ago

Reviewers:
hirono

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix ejecting if the element is not selected. This patch fixes a recent regression, which was incorrectly taking the selection instead of the element the eject button is on. TEST=Tested manually with archives. BUG=337577 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247696

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	chrome/browser/resources/file_manager/foreground/js/file_manager_commands.js	View		1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/131103020/1

6 years, 10 months ago (2014-01-29 10:37:47 UTC) #3

commit-bot: I haz the power

Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=144062

6 years, 10 months ago (2014-01-29 11:46:08 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/131103020/1

6 years, 10 months ago (2014-01-29 11:57:11 UTC) #5

Message was sent while issue was closed.

Change committed as 247696

Expand Messages | Collapse Messages