Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 131103007: Add chrome://nfc-debug for debugging NFC on Chrome OS. (Closed)

Created:
6 years, 11 months ago by armansito
Modified:
6 years, 11 months ago
Reviewers:
keybuk, xiyuan, stevenjb, Nico
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Add chrome://nfc-debug for debugging NFC on Chrome OS. Wrote a simple WebUI page that demonstrates the functionality of the NFC API defined in device/nfc. This is primarily meant for testing and demo purposes. BUG=336687 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247118

Patch Set 1 #

Patch Set 2 : Reupload. #

Total comments: 34

Patch Set 3 : Addressed comments by xiyuan@ and stevenjb@. #

Total comments: 8

Patch Set 4 : Addressed xiyuan@'s comments. #

Total comments: 5

Patch Set 5 : Addressed thaki@'s comment. Fixed a couple of minor issues. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1468 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +88 lines, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/nfc_debug.css View 1 2 1 chunk +85 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/nfc_debug.html View 1 2 3 1 chunk +130 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/nfc_debug.js View 1 2 3 1 chunk +375 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +3 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/chromeos/nfc_debug_ui.h View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc View 1 2 3 4 1 chunk +752 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/common/url_constants.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_nfc_adapter_client.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
armansito
6 years, 11 months ago (2014-01-22 04:46:30 UTC) #1
armansito
6 years, 11 months ago (2014-01-22 04:47:09 UTC) #2
stevenjb
Upload failed on a bunch of these files, can you try uploading again? +xiyuan for ...
6 years, 11 months ago (2014-01-23 18:22:57 UTC) #3
xiyuan
Please re-upload. The patch has a bad base file and could not see anything for ...
6 years, 11 months ago (2014-01-23 19:32:02 UTC) #4
xiyuan
https://codereview.chromium.org/131103007/diff/220001/chrome/browser/resources/chromeos/nfc_debug.css File chrome/browser/resources/chromeos/nfc_debug.css (right): https://codereview.chromium.org/131103007/diff/220001/chrome/browser/resources/chromeos/nfc_debug.css#newcode7 chrome/browser/resources/chromeos/nfc_debug.css:7: font-family: Arial, Helvetica, sans-serif; Usually we don't set font ...
6 years, 11 months ago (2014-01-23 21:20:54 UTC) #5
stevenjb
https://codereview.chromium.org/131103007/diff/220001/chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc File chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc (right): https://codereview.chromium.org/131103007/diff/220001/chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc#newcode121 chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc:121: default: remove default so that compiler will catch addition ...
6 years, 11 months ago (2014-01-23 21:57:56 UTC) #6
armansito
https://codereview.chromium.org/131103007/diff/220001/chrome/browser/resources/chromeos/nfc_debug.css File chrome/browser/resources/chromeos/nfc_debug.css (right): https://codereview.chromium.org/131103007/diff/220001/chrome/browser/resources/chromeos/nfc_debug.css#newcode7 chrome/browser/resources/chromeos/nfc_debug.css:7: font-family: Arial, Helvetica, sans-serif; On 2014/01/23 21:20:55, xiyuan wrote: ...
6 years, 11 months ago (2014-01-24 20:50:33 UTC) #7
xiyuan
LGTM https://codereview.chromium.org/131103007/diff/300001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/131103007/diff/300001/chrome/app/generated_resources.grd#newcode15446 chrome/app/generated_resources.grd:15446: + <if expr="pp_ifdef('chromeos')"> nit: If the strings are ...
6 years, 11 months ago (2014-01-24 22:18:03 UTC) #8
armansito
https://codereview.chromium.org/131103007/diff/300001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/131103007/diff/300001/chrome/app/generated_resources.grd#newcode15446 chrome/app/generated_resources.grd:15446: + <if expr="pp_ifdef('chromeos')"> On 2014/01/24 22:18:04, xiyuan wrote: > ...
6 years, 11 months ago (2014-01-24 22:40:14 UTC) #9
stevenjb
lgtm w/ one suggestion https://codereview.chromium.org/131103007/diff/230012/chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc File chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc (right): https://codereview.chromium.org/131103007/diff/230012/chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc#newcode422 chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc:422: DCHECK(result); nit: If the source ...
6 years, 11 months ago (2014-01-24 23:33:52 UTC) #10
armansito
https://codereview.chromium.org/131103007/diff/230012/chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc File chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc (right): https://codereview.chromium.org/131103007/diff/230012/chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc#newcode422 chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc:422: DCHECK(result); On 2014/01/24 23:33:53, stevenjb wrote: > nit: If ...
6 years, 11 months ago (2014-01-24 23:40:40 UTC) #11
xiyuan
https://codereview.chromium.org/131103007/diff/230012/chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc File chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc (right): https://codereview.chromium.org/131103007/diff/230012/chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc#newcode422 chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc:422: DCHECK(result); On 2014/01/24 23:40:41, armansito wrote: > On 2014/01/24 ...
6 years, 11 months ago (2014-01-24 23:53:23 UTC) #12
armansito
thakis@: For browser_resources.grd keybuk@: For device/nfc being added in DEPS
6 years, 11 months ago (2014-01-24 23:53:56 UTC) #13
Nico
grd lgtm https://codereview.chromium.org/131103007/diff/230012/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/131103007/diff/230012/chrome/app/generated_resources.grd#newcode15456 chrome/app/generated_resources.grd:15456: + <message name="IDS_NFC_DEBUG_ADAPTER_POWER_ON" desc="Adapter power on button ...
6 years, 11 months ago (2014-01-24 23:58:58 UTC) #14
keybuk
lgtm
6 years, 11 months ago (2014-01-25 00:28:06 UTC) #15
armansito
https://codereview.chromium.org/131103007/diff/230012/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/131103007/diff/230012/chrome/app/generated_resources.grd#newcode15456 chrome/app/generated_resources.grd:15456: + <message name="IDS_NFC_DEBUG_ADAPTER_POWER_ON" desc="Adapter power on button text"> On ...
6 years, 11 months ago (2014-01-25 03:20:29 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/131103007/490001
6 years, 11 months ago (2014-01-25 07:23:29 UTC) #17
commit-bot: I haz the power
6 years, 11 months ago (2014-01-25 11:10:06 UTC) #18
Message was sent while issue was closed. 
Change committed as 247118

Powered by Google App Engine
This is Rietveld 408576698