Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 131103003: CSP: Add a mechanism to disable CSP 1.1 for layout tests. (Closed)

Created:
6 years, 11 months ago by Mike West
Modified:
6 years, 11 months ago
CC:
blink-reviews, arv+blink, Inactive, mkwst+watchlist_chromium.org, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

CSP: Add a mechanism to disable CSP 1.1 for layout tests. In order to test some changes to report-only for CSP 1.1, we need a mechanism by which we can disable 1.1 when running layout tests. This patch adds a flag to 'window.internal.settings', and toggles it off for report-only tests. This changes the result by removing the 'effective-directive' attribute from the report JSON, which was first added in 1.1. BUG=335489 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -18 lines) Patch
M LayoutTests/http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode.html View 1 chunk +6 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode-and-sends-report.html View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode-and-sends-report-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-only-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-scheme-relative-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/contentSecurityPolicy/resources/report-test.js View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/testing/InternalSettings.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/testing/InternalSettings.cpp View 3 chunks +7 lines, -0 lines 0 comments Download
M Source/core/testing/InternalSettings.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike West
Jochen, WDYT? :)
6 years, 11 months ago (2014-01-21 09:03:59 UTC) #1
jochen (gone - plz use gerrit)
I guess you know exactly what the runtime flag does, and that it's safe to ...
6 years, 11 months ago (2014-01-21 09:07:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/131103003/1
6 years, 11 months ago (2014-01-21 09:10:00 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-21 10:13:00 UTC) #4
Message was sent while issue was closed. 
Change committed as 165446

Powered by Google App Engine
This is Rietveld 408576698