No longer any need to delete the line box tree on our own.

No longer any need to delete the line box tree on our own.

The LayoutBlockFlow::moveChildrenTo() override takes of that for us.

BUG=327070
R=szager@chromium.org

Committed: https://crrev.com/3a075d30c13232248bd57be5b076b46855ecafa3
git-svn-id: svn://svn.chromium.org/blink/trunk@202200 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[mstensho (USE GERRIT), 2015-09-11 12:14:53]

ping

[leviw_travelin_and_unemployed, 2015-09-11 15:38:39]

leviw@chromium.org changed reviewers:
+ leviw@chromium.org

[leviw_travelin_and_unemployed, 2015-09-11 15:38:39]

lgtm

https://codereview.chromium.org/1311023003/diff/1/Source/core/layout/LayoutMu...
File Source/core/layout/LayoutMultiColumnFlowThread.cpp (left):

https://codereview.chromium.org/1311023003/diff/1/Source/core/layout/LayoutMu...
Source/core/layout/LayoutMultiColumnFlowThread.cpp:262: deleteLineBoxTree();
Perhaps assert !firstLineBox?

[mstensho (USE GERRIT), 2015-09-11 18:03:49]

https://codereview.chromium.org/1311023003/diff/1/Source/core/layout/LayoutMu...
File Source/core/layout/LayoutMultiColumnFlowThread.cpp (left):

https://codereview.chromium.org/1311023003/diff/1/Source/core/layout/LayoutMu...
Source/core/layout/LayoutMultiColumnFlowThread.cpp:262: deleteLineBoxTree();
On 2015/09/11 15:38:39, leviw OOO thru 9-9 )( wrote:
> Perhaps assert !firstLineBox?

And readers of the code will go "huh?", but I can add a comment too. :)

Done.

[szager1, 2015-09-14 04:34:59]

Sorry, this one flew under my radar.

lgtm

[mstensho (USE GERRIT), 2015-09-14 07:27:34]

The CQ bit was checked by mstensho@opera.com

[mstensho (USE GERRIT), 2015-09-14 07:27:34]

The patchset sent to the CQ was uploaded after l-g-t-m from leviw@chromium.org
Link to the patchset: https://codereview.chromium.org/1311023003/#ps20001
(title: "code review")

[commit-bot: I haz the power, 2015-09-14 07:27:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311023003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311023003/20001

[commit-bot: I haz the power, 2015-09-14 08:19:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 08:19:27]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mstensho (USE GERRIT), 2015-09-14 13:41:24]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2015-09-14 13:41:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311023003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311023003/20001

[commit-bot: I haz the power, 2015-09-14 13:58:51]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202200

[commit-bot: I haz the power, 2015-09-23 12:32:02]

Patchset 2 (id:??) landed as
https://crrev.com/3a075d30c13232248bd57be5b076b46855ecafa3