Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
5 years, 3 months ago by mstensho (USE GERRIT) Modified:
5 years, 3 months ago Reviewers:
leviw_travelin_and_unemployed, szager1 CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1 Base URL:
svn://svn.chromium.org/blink/trunk Target Ref:
refs/remotes/origin/master Project:
blink Visibility:
Public. |
DescriptionNo longer any need to delete the line box tree on our own.
The LayoutBlockFlow::moveChildrenTo() override takes of that for us.
BUG=327070
R=szager@chromium.org
Committed: https://crrev.com/3a075d30c13232248bd57be5b076b46855ecafa3
git-svn-id: svn://svn.chromium.org/blink/trunk@202200 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Patch Set 1 #
Total comments: 2
Patch Set 2 : code review #
Created: 5 years, 3 months ago
Messages
Total messages: 17 (5 generated)
ping
leviw@chromium.org changed reviewers: + leviw@chromium.org
lgtm https://codereview.chromium.org/1311023003/diff/1/Source/core/layout/LayoutMu... File Source/core/layout/LayoutMultiColumnFlowThread.cpp (left): https://codereview.chromium.org/1311023003/diff/1/Source/core/layout/LayoutMu... Source/core/layout/LayoutMultiColumnFlowThread.cpp:262: deleteLineBoxTree(); Perhaps assert !firstLineBox?
https://codereview.chromium.org/1311023003/diff/1/Source/core/layout/LayoutMu... File Source/core/layout/LayoutMultiColumnFlowThread.cpp (left): https://codereview.chromium.org/1311023003/diff/1/Source/core/layout/LayoutMu... Source/core/layout/LayoutMultiColumnFlowThread.cpp:262: deleteLineBoxTree(); On 2015/09/11 15:38:39, leviw OOO thru 9-9 )( wrote: > Perhaps assert !firstLineBox? And readers of the code will go "huh?", but I can add a comment too. :) Done.
Sorry, this one flew under my radar. lgtm
The CQ bit was checked by mstensho@opera.com
The patchset sent to the CQ was uploaded after l-g-t-m from leviw@chromium.org Link to the patchset: https://codereview.chromium.org/1311023003/#ps20001 (title: "code review")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311023003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mstensho@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311023003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202200
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3a075d30c13232248bd57be5b076b46855ecafa3 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
