[builtins] Unify the various versions of [[Call]] with a Call builtin.

[builtins] Unify the various versions of [[Call]] with a Call builtin.

The new Call and CallFunction builtins supersede the current
CallFunctionStub (and CallIC magic) and will be the single bottleneck
for all calling, including the currently special Function.prototype.call
and Function.prototype.apply builtins, which had handwritten (and
not fully compliant) versions of CallFunctionStub, and also the
CallIC(s), which where also slightly different.

This also reduces the overhead for API function calls, which is still
unnecessary high, but let's do that step-by-step.

This also fixes a bunch of cases where the implicit ToObject for
sloppy receivers was done in the wrong context (in the caller
context instead of the callee context), which basically meant
that we allowed cross context access to %ObjectPrototype%.

MIPS and MIPS64 ports contributed by akos.palfi@imgtec.com.

R=mstarzinger@chromium.org, jarin@chromium.org, mvstanton@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_layout_dbg,v8_linux_nosnap_dbg
BUG=v8:4413
LOG=n

Committed: https://crrev.com/ef268a83be4dead004047c25b702319ea4be7277
Cr-Commit-Position: refs/heads/master@{#30627}

Committed: https://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744
Cr-Commit-Position: refs/heads/master@{#30629}

[Benedikt Meurer, 2015-09-04 17:47:08]

bmeurer@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[Benedikt Meurer, 2015-09-04 17:47:08]

Hey Ross,

This is the very first version of the CallCallableStub. You said you wanted to
have an early look. It'll need some more polishing. If you have some spare time,
you can help porting to arm/arm64 next week.

greets,
Benedikt

[Benedikt Meurer, 2015-09-04 18:56:38]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-04 18:56:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311013008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311013008/20001

[commit-bot: I haz the power, 2015-09-04 18:59:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-04 18:59:35]

Dry run: Try jobs failed on following builders:
  v8_linux_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/9367)

[Benedikt Meurer, 2015-09-04 20:12:14]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-04 20:12:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311013008/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311013008/40001

[commit-bot: I haz the power, 2015-09-04 20:14:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-04 20:14:16]

Dry run: Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[Benedikt Meurer, 2015-09-06 17:12:51]

Patchset #3 (id:40001) has been deleted

[Benedikt Meurer, 2015-09-07 05:41:27]

Patchset #5 (id:100001) has been deleted

[Benedikt Meurer, 2015-09-07 06:47:07]

bmeurer@chromium.org changed reviewers:
+ jarin@chromium.org

[Benedikt Meurer, 2015-09-07 06:47:07]

bmeurer@chromium.org changed required reviewers:
+ jarin@chromium.org

[Benedikt Meurer, 2015-09-07 06:47:08]

Hey Jaro,

Can you take a look at the x64 port before I start porting that over to
everything else?

Thanks,
Benedikt

[Benedikt Meurer, 2015-09-07 07:13:29]

Hey MIPS guys,

Please port this CL to mips/mips64.

Thanks,
Benedikt

[Jarin, 2015-09-07 07:49:43]

looks good so far.

https://codereview.chromium.org/1311013008/diff/80001/src/x64/builtins-x64.cc
File src/x64/builtins-x64.cc (right):

https://codereview.chromium.org/1311013008/diff/80001/src/x64/builtins-x64.cc...
src/x64/builtins-x64.cc:1732: // TODO(bmeurer): This doesn't match the ES6 spec
for [[Call]] on proxies.
You might want to add @neis to this TODO.

[Benedikt Meurer, 2015-09-07 08:05:23]

bmeurer@chromium.org changed reviewers:
+ mstarzinger@chromium.org, mvstanton@chromium.org

[Benedikt Meurer, 2015-09-07 08:05:24]

Hey Michi, Michael,

Please review the x64 or ia32 port (i'm about to port to arm).
Please take a look.

Thanks,
Benedikt

[mvstanton, 2015-09-07 09:06:50]

Code-stubs-* is looking good.

https://codereview.chromium.org/1311013008/diff/120001/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/1311013008/diff/120001/src/code-stubs.h#newco...
src/code-stubs.h:1957: // and less horrible Invoke family of builtins.
oh come on. 's/and less horrible//' :)

[Benedikt Meurer, 2015-09-07 09:14:34]

https://codereview.chromium.org/1311013008/diff/80001/src/x64/builtins-x64.cc
File src/x64/builtins-x64.cc (right):

https://codereview.chromium.org/1311013008/diff/80001/src/x64/builtins-x64.cc...
src/x64/builtins-x64.cc:1732: // TODO(bmeurer): This doesn't match the ES6 spec
for [[Call]] on proxies.
On 2015/09/07 07:49:43, Jarin wrote:
> You might want to add @neis to this TODO.

Done.

https://codereview.chromium.org/1311013008/diff/120001/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/1311013008/diff/120001/src/code-stubs.h#newco...
src/code-stubs.h:1957: // and less horrible Invoke family of builtins.
On 2015/09/07 09:06:49, mvstanton wrote:
> oh come on. 's/and less horrible//' :)

Done.

[Benedikt Meurer, 2015-09-07 09:17:54]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-07 09:18:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311013008/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311013008/140001

[commit-bot: I haz the power, 2015-09-07 09:21:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-07 09:21:16]

Dry run: Try jobs failed on following builders:
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[Benedikt Meurer, 2015-09-07 10:55:55]

bmeurer@chromium.org changed required reviewers:
+ mstarzinger@chromium.org, mvstanton@chromium.org

[rmcilroy, 2015-09-07 11:01:19]

Overall looks good, should be something that can be used by the Interpreter. I
tried to figure out how to modify my CL to call this instead of the JSFunction
code object directly, however I couldn't find a way to call a non-JS builtin
from TF - is this not possible or am I missing something obvious?

[Benedikt Meurer, 2015-09-07 11:04:30]

On 2015/09/07 11:01:19, rmcilroy wrote:
> Overall looks good, should be something that can be used by the Interpreter. I
> tried to figure out how to modify my CL to call this instead of the JSFunction
> code object directly, however I couldn't find a way to call a non-JS builtin
> from TF - is this not possible or am I missing something obvious?

It's just a regular code object. You need to provide a Callable for it in
CodeFactory.
Though this one might be a bit special since it takes a variable number of
arguments (which tho should be hidden by your CallVarArgs).

[rmcilroy, 2015-09-07 11:26:42]

> It's just a regular code object. You need to provide a Callable for it in
> CodeFactory.
> Though this one might be a bit special since it takes a variable number of
> arguments (which tho should be hidden by your CallVarArgs).

I thought this might be the case, thanks (just wanted to makes sure since it
doesn't look like there are any builtins there yet, all of them seemed to be
code-stubs).

[Michael Starzinger, 2015-09-07 11:53:21]

LGTM.

[Jarin, 2015-09-07 13:02:30]

lgtm

[mvstanton, 2015-09-07 13:25:39]

LGTM here too.

[rmcilroy, 2015-09-07 13:42:33]

Just tried this with the interpreter CallJS WIP CL and it works fine. LGTM,
thanks!

[Benedikt Meurer, 2015-09-07 18:32:52]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-07 18:32:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311013008/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311013008/200001

[commit-bot: I haz the power, 2015-09-07 18:35:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-07 18:35:07]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[Benedikt Meurer, 2015-09-07 18:38:50]

Patchset #9 (id:200001) has been deleted

[Benedikt Meurer, 2015-09-07 19:01:34]

I renamed the builtins to Call and CallFunction to better match the spec names.

[paul.l..., 2015-09-08 04:09:44]

Hey Benedikt - Please find MIPS ports from Ákos in
https://codereview.chromium.org/1311003006/

[Benedikt Meurer, 2015-09-08 04:15:29]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-09-08 04:15:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, mvstanton@chromium.org, jarin@chromium.org,
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1311013008/#ps260001
(title: "Merge MIPS/MIPS64 ports from akos.palfi@imgtec.com.")

[commit-bot: I haz the power, 2015-09-08 04:15:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311013008/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311013008/260001

[Benedikt Meurer, 2015-09-08 04:34:41]

Patchset #9 (id:220001) has been deleted

[commit-bot: I haz the power, 2015-09-08 05:06:36]

Committed patchset #10 (id:260001)

[commit-bot: I haz the power, 2015-09-08 05:06:56]

Patchset 10 (id:??) landed as
https://crrev.com/ef268a83be4dead004047c25b702319ea4be7277
Cr-Commit-Position: refs/heads/master@{#30627}

[Benedikt Meurer, 2015-09-08 06:11:56]

A revert of this CL (patchset #10 id:260001) has been created in
https://codereview.chromium.org/1328963004/ by bmeurer@chromium.org.

The reason for reverting is: Breaks nosnap, needs investigation.

[Benedikt Meurer, 2015-09-08 06:26:06]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-09-08 06:26:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org, jarin@chromium.org, rmcilroy@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1311013008/#ps280001
(title: "AssertFunction was wrong")

[commit-bot: I haz the power, 2015-09-08 06:26:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311013008/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311013008/280001

[Benedikt Meurer, 2015-09-08 06:29:35]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2015-09-08 06:30:09]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-09-08 06:30:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311013008/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311013008/280001

[commit-bot: I haz the power, 2015-09-08 07:50:27]

Committed patchset #11 (id:280001)

[commit-bot: I haz the power, 2015-09-08 07:50:44]

Patchset 11 (id:??) landed as
https://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744
Cr-Commit-Position: refs/heads/master@{#30629}