Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311013007: Add model listeners in the Security panel constructor (instead of in targetAdded). (Closed)

Created:
5 years, 3 months ago by lgarron
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add model listeners in the Security panel constructor (instead of in targetAdded). BUG=522762 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -18 lines) Patch
M Source/devtools/front_end/security/SecurityPanel.js View 3 chunks +4 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
lgarron
Pavel, would you mind reviewing?
5 years, 3 months ago (2015-09-02 01:36:47 UTC) #2
pfeldman
lgtm
5 years, 3 months ago (2015-09-02 01:42:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311013007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311013007/1
5 years, 3 months ago (2015-09-02 01:44:12 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 02:54:18 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201603

Powered by Google App Engine
This is Rietveld 408576698