Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311013004: DevTools: Smooth CPU utilization overview chart on timeline (Closed)

Created:
5 years, 3 months ago by alph
Modified:
5 years, 3 months ago
Reviewers:
caseq, yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Smooth CPU utilization overview chart on timeline NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201167

Patch Set 1 #

Total comments: 2

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M Source/devtools/front_end/timeline/TimelineEventOverview.js View 1 3 chunks +19 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
alph
5 years, 3 months ago (2015-08-25 20:55:19 UTC) #2
caseq
lgtm https://codereview.chromium.org/1311013004/diff/1/Source/devtools/front_end/timeline/TimelineEventOverview.js File Source/devtools/front_end/timeline/TimelineEventOverview.js (right): https://codereview.chromium.org/1311013004/diff/1/Source/devtools/front_end/timeline/TimelineEventOverview.js#newcode348 Source/devtools/front_end/timeline/TimelineEventOverview.js:348: paths[i].moveTo(-1, height + 1); 0, height?
5 years, 3 months ago (2015-08-25 21:35:57 UTC) #3
alph
https://codereview.chromium.org/1311013004/diff/1/Source/devtools/front_end/timeline/TimelineEventOverview.js File Source/devtools/front_end/timeline/TimelineEventOverview.js (right): https://codereview.chromium.org/1311013004/diff/1/Source/devtools/front_end/timeline/TimelineEventOverview.js#newcode348 Source/devtools/front_end/timeline/TimelineEventOverview.js:348: paths[i].moveTo(-1, height + 1); On 2015/08/25 21:35:56, caseq wrote: ...
5 years, 3 months ago (2015-08-25 21:36:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311013004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311013004/20001
5 years, 3 months ago (2015-08-25 21:37:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/104206)
5 years, 3 months ago (2015-08-25 23:16:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311013004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311013004/20001
5 years, 3 months ago (2015-08-25 23:17:13 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-08-25 23:22:00 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201167

Powered by Google App Engine
This is Rietveld 408576698