ui/ozone/platform/drm/host/drm_overlay_candidates_host.cc - Issue 1311013002: [Ozone] Fix SingleOnTop issue by checking if the quad is clipped.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/ozone/platform/drm/host/drm_overlay_candidates_host.cc

Issue 1311013002: [Ozone] Fix SingleOnTop issue by checking if the quad is clipped. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Allow clipped Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/compositor/browser_compositor_overlay_candidate_validator_ozone.cc ('k') | ui/ozone/public/overlay_candidates_ozone.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/ozone/platform/drm/host/drm_overlay_candidates_host.cc

diff --git a/ui/ozone/platform/drm/host/drm_overlay_candidates_host.cc b/ui/ozone/platform/drm/host/drm_overlay_candidates_host.cc

index 52e31b158230b4d40f17c75d833ebff7b9afd1b7..2fcbe8c90a8f4309bb0adb8bb0fbb069cf25c386 100644

--- a/ui/ozone/platform/drm/host/drm_overlay_candidates_host.cc

+++ b/ui/ozone/platform/drm/host/drm_overlay_candidates_host.cc

@@ -79,6 +79,9 @@ void DrmOverlayCandidatesHost::CheckSingleOverlay(

return;

if (overlay->transform == gfx::OVERLAY_TRANSFORM_INVALID)

return;

+ if (overlay->is_clipped &&

danakj 2015/09/03 22:21:17 Where does this file get tested?

+ !overlay->clip_rect.Contains(overlay->quad_rect_in_target_space))

+ return;

OverlayCheck_Params lookup(*overlay);

auto iter = cache_.Get(lookup);