Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1311003006: MIPS: [builtins] Unify the various versions of [[Call]] with a Call builtin. (Closed)

Created:
5 years, 3 months ago by akos.palfi.imgtec
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [builtins] Unify the various versions of [[Call]] with a Call builtin. Port of https://codereview.chromium.org/1311013008/ Original commit message: The new Call and CallFunction builtins supersede the current CallFunctionStub (and CallIC magic) and will be the single bottleneck for all calling, including the currently special Function.prototype.call and Function.prototype.apply builtins, which had handwritten (and not fully compliant) versions of CallFunctionStub, and also the CallIC(s), which where also slightly different. This also reduces the overhead for API function calls, which is still unnecessary high, but let's do that step-by-step. This also fixes a bunch of cases where the implicit ToObject for sloppy receivers was done in the wrong context (in the caller context instead of the callee context), which basically meant that we allowed cross context access to %ObjectPrototype%. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+428 lines, -529 lines) Patch
M src/mips/builtins-mips.cc View 5 chunks +160 lines, -227 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 7 chunks +11 lines, -37 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 3 chunks +24 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 3 chunks +20 lines, -0 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 5 chunks +158 lines, -227 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 7 chunks +12 lines, -38 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 3 chunks +24 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
paul.l...
rs-l-g-t-m (I'm OOO today) for inclusion in https://codereview.chromium.org/1311013008/ optdebug 'check' suite passes all tests.
5 years, 3 months ago (2015-09-08 04:08:52 UTC) #2
Benedikt Meurer
5 years, 3 months ago (2015-09-08 04:15:54 UTC) #3
Amazing. Thanks a lot!

Powered by Google App Engine
This is Rietveld 408576698