Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1311003004: Presentation API: mark session required in PresentationSessionConnectEventInit. (Closed)

Created:
5 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 3 months ago
Reviewers:
whywhat
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Presentation API: mark session required in PresentationSessionConnectEventInit. See spec change: https://github.com/w3c/presentation-api/issues/184 BUG=529051 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201971

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/modules/presentation/PresentationSessionConnectEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/presentation/PresentationSessionConnectEventInit.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
mlamouri (slow - plz ping)
5 years, 3 months ago (2015-09-07 17:31:06 UTC) #2
mlamouri (slow - plz ping)
This should probably wait for the spec change to be merged into the spec.
5 years, 3 months ago (2015-09-07 17:31:37 UTC) #3
whywhat
lgtm
5 years, 3 months ago (2015-09-07 18:09:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311003004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311003004/1
5 years, 3 months ago (2015-09-08 21:49:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/66306)
5 years, 3 months ago (2015-09-09 00:46:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311003004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311003004/1
5 years, 3 months ago (2015-09-09 10:31:35 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 11:33:07 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201971

Powered by Google App Engine
This is Rietveld 408576698