snapshot/win/module_snapshot_win.cc - Issue 1311003003: Implement ModuleSnapshotWin::UUID

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/win/module_snapshot_win.cc

Issue 1311003003: Implement ModuleSnapshotWin::UUID (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: . Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: snapshot/win/module_snapshot_win.cc

diff --git a/snapshot/win/module_snapshot_win.cc b/snapshot/win/module_snapshot_win.cc

index 1819a45baa1808c150ab7fc8e3e10679054c813e..f1536f5599e0553dba931a86d68c5aefda840ac1 100644

--- a/snapshot/win/module_snapshot_win.cc

+++ b/snapshot/win/module_snapshot_win.cc

@@ -148,7 +148,10 @@ ModuleSnapshot::ModuleType ModuleSnapshotWin::GetModuleType() const {

void ModuleSnapshotWin::UUID(crashpad::UUID* uuid) const {

INITIALIZATION_STATE_DCHECK_VALID(initialized_);

- CHECK(false) << "TODO(scottmg)";

+ // TODO(scottmg): Also pass the age and pdbname through to snapshot?

+ DWORD age;

+ std::string pdbname;

+ pe_image_reader_->DebugDirectoryInformation(uuid, &age, &pdbname);

Mark Mentovai 2015/08/31 21:48:20 If this fails, reinitialize uuid to the default UU

scottmg 2015/08/31 23:05:01 Done.

}

std::vector<std::string> ModuleSnapshotWin::AnnotationsVector() const {

« no previous file with comments | « no previous file | snapshot/win/pe_image_reader.h » ('j') | snapshot/win/pe_image_reader.h » ('J')