Issue 1311003: Refactor code to reduce stack use when compiling nested binary operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1311003: Refactor code to reduce stack use when compiling nested binary operations. (Closed)

Created:
10 years, 9 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Refactor code to reduce stack use when compiling nested binary operations.

Patch Set 2 : '' #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -25 lines)			Patch
M	src/arm/codegen-arm.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View	1	4 chunks	+16 lines, -11 lines	0 comments	Download
M	src/ia32/codegen-ia32.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1	4 chunks	+12 lines, -5 lines	1 comment	Download
M	src/x64/codegen-x64.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1	4 chunks	+11 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

Fixes the failure on large-expression layout test.

10 years, 9 months ago (2010-03-25 17:14:32 UTC) #1

Rico

LGTM with ASSERT corrected. http://codereview.chromium.org/1311003/diff/8001/9001 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/1311003/diff/8001/9001#newcode7503 src/ia32/codegen-ia32.cc:7503: ASSERT(op == Token::OR); This should ...

10 years, 9 months ago (2010-03-26 07:28:26 UTC) #2