Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 131096: Only select scalable fonts.... (Closed)

Created:
11 years, 6 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
agl, Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Only select scalable fonts. Fixed-size fonts don't work with FT_Set_Char_Size in SkFontHost_FreeType.cpp. BUG=13007 TEST=On Linux, visit url with { font-family: fixed; } on a computer with pcf fonts. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18832

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M skia/ext/SkFontHost_fontconfig_direct.cpp View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
This fixes bug 13007 for me, but we should also commit http://codereview.appspot.com/79052
11 years, 6 months ago (2009-06-19 06:34:01 UTC) #1
Evan Martin
Could you make both the commit description and the comment in the code describe why ...
11 years, 6 months ago (2009-06-19 14:42:39 UTC) #2
Lei Zhang
On 2009/06/19 14:42:39, Evan Martin wrote: > Could you make both the commit description and ...
11 years, 6 months ago (2009-06-19 18:02:04 UTC) #3
Evan Martin
11 years, 6 months ago (2009-06-19 18:05:19 UTC) #4
LGTM

(It might be more descriptive to point out that why they don't work with
FT_Set_Char_Size...  and to mention the test passes if you don't crash.)

Powered by Google App Engine
This is Rietveld 408576698