Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 1310953005: Move {left,right}PositionOf() for VisiblePosition to VisibleUnits.cpp (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move {left,right}PositionOf() for VisiblePosition to VisibleUnits.cpp This patch moves |{left,right}PositionOf()| for |VisiblePosition| to "VisibleUnits.cpp" form "VisiblePosition.cpp" to make "VisiblePosition.cpp" to simpler for improving code health and ease of templatizing |VisiblePosition| class to introduce composed tree version. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201595

Patch Set 1 : 2015-09-01T21:47:52 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -336 lines) Patch
M Source/core/editing/VisiblePosition.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 1 chunk +0 lines, -331 lines 0 comments Download
M Source/core/editing/VisibleUnits.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 chunk +329 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-09-01 13:07:24 UTC) #2
yoichio
lgtm
5 years, 3 months ago (2015-09-02 00:54:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310953005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310953005/1
5 years, 3 months ago (2015-09-02 00:55:46 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 01:53:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201595

Powered by Google App Engine
This is Rietveld 408576698