Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Issue 1310953002: Use DescriptorArray when checking if an object has a property (Closed)

Created:
5 years, 4 months ago by hichris123
Modified:
5 years, 2 months ago
Reviewers:
Toon Verwaest, danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use DescriptorArray when checking if an object has a property DescriptorArray provides a faster idea of if an object has a property. Use it for JSReceiver::HasProperty & JSObject::HasRealNamedProperty. BUG=v8:2472 LOG=N

Patch Set 1 #

Patch Set 2 : Add fallback #

Patch Set 3 : Look up prototype chain #

Patch Set 4 : Add check if it's a JSReceiver #

Patch Set 5 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M src/objects.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 2 3 4 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
hichris123
verwaest@/danno@: PTAL. This should speed up `"y" in x` and `x.hasOwnProperty("y")`. One thing is I ...
5 years, 4 months ago (2015-08-24 02:22:30 UTC) #3
Toon Verwaest
Does not lgtm, exactly since it skips all the work that is required to do ...
5 years, 2 months ago (2015-10-02 08:17:56 UTC) #4
hichris123
5 years, 2 months ago (2015-10-02 14:50:57 UTC) #5
On 2015/10/02 08:17:56, Toon Verwaest wrote:
> Does not lgtm, exactly since it skips all the work that is required to do a
> correct (and secure) lookup. The LookupIterator does exactly the work that is
> necessary, not more.
> 
> That's not to say there are no other optimizations possible. We already have
> those on our roadmap though.

Ah yeah, I probably should've closed this review earlier. I was looking into
better options... and I kinda forgot about this CL.

Powered by Google App Engine
This is Rietveld 408576698