Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1310943005: fix `dynamic` type literal (Closed)

Created:
5 years, 3 months ago by Jennifer Messerly
Modified:
5 years, 3 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M lib/src/codegen/js_module_item_order.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M test/browser/language_tests.js View 1 1 chunk +6 lines, -0 lines 0 comments Download
M test/codegen/expect/sunflower/sunflower.html View 1 1 chunk +1 line, -1 line 0 comments Download
A test/codegen/language/const_dynamic_type_literal_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
5 years, 3 months ago (2015-09-04 22:41:10 UTC) #2
Leaf
lgtm
5 years, 3 months ago (2015-09-04 22:45:09 UTC) #3
Jennifer Messerly
5 years, 3 months ago (2015-09-04 22:57:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3516c4c1d3060068a26c8466f66a85d358575008 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698