Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 131093004: [DevTools] Update DevTools after bookmarks and infobar. (Closed)

Created:
6 years, 11 months ago by dgozman
Modified:
6 years, 11 months ago
Reviewers:
Avi (use Gerrit), Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[DevTools] Update DevTools after bookmarks and infobar. Previously, updating bookmark bar could have cause page/devtools resize. With new layout logic implemented in DevToolsController, resizing page/devtools after everything else guarantees single resize operation. BUG=331295 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245628

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dgozman
Could you please take a look?
6 years, 11 months ago (2014-01-14 16:21:19 UTC) #1
dgozman
Avi, could you please take a look?
6 years, 11 months ago (2014-01-16 10:12:52 UTC) #2
dgozman
Nico, could you please have a look?
6 years, 11 months ago (2014-01-17 10:51:58 UTC) #3
Nico
lgtm stamp
6 years, 11 months ago (2014-01-17 17:50:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/131093004/1
6 years, 11 months ago (2014-01-17 19:12:22 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 21:46:51 UTC) #6
Message was sent while issue was closed.
Change committed as 245628

Powered by Google App Engine
This is Rietveld 408576698