Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 131093003: Update accessibility classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
Reviewers:
dmazzoni, eseidel
CC:
blink-reviews, dmazzoni, aboxhall
Visibility:
Public.

Description

Update accessibility classes to use OVERRIDE / FINAL when needed Update accessibility classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. R=eseidel, dmazzoni@chromium.org BUG=333316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164931

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -95 lines) Patch
M Source/core/accessibility/AXARIAGrid.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AXARIAGridCell.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/accessibility/AXARIAGridRow.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/accessibility/AXImageMapLink.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/accessibility/AXInlineTextBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AXList.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/accessibility/AXListBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AXListBoxOption.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AXMediaControls.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/accessibility/AXMenuList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AXMenuListOption.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AXMenuListPopup.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AXMockObject.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/accessibility/AXNodeObject.h View 3 chunks +32 lines, -32 lines 0 comments Download
M Source/core/accessibility/AXProgressIndicator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/accessibility/AXRenderObject.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/accessibility/AXSVGRoot.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AXScrollView.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/accessibility/AXScrollbar.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/accessibility/AXSlider.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/accessibility/AXSpinButton.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/accessibility/AXTable.h View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/accessibility/AXTableCell.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/accessibility/AXTableColumn.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AXTableHeaderContainer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AXTableRow.h View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 11 months ago (2014-01-11 05:56:00 UTC) #1
eseidel
lgtm I wish we had a way to enforce this automagically.
6 years, 11 months ago (2014-01-11 06:43:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/131093003/1
6 years, 11 months ago (2014-01-11 06:44:03 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-11 06:50:42 UTC) #4
Message was sent while issue was closed. 
Change committed as 164931

Powered by Google App Engine
This is Rietveld 408576698