FFmpegDemuxerStream::Read() now functions properly while stopped.

media/filters/ffmpeg_demuxer_unittest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <deque>
 
 #include "base/singleton.h"
 #include "base/tuple.h"
 #include "media/base/filter_host.h"
 #include "media/base/filters.h"
 #include "media/base/mock_ffmpeg.h"
 #include "media/base/mock_filter_host.h"
 #include "media/base/mock_media_filters.h"
 #include "media/base/mock_reader.h"
 #include "media/filters/ffmpeg_common.h"
 #include "media/filters/ffmpeg_demuxer.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using ::testing::_;
 using ::testing::DoAll;
 using ::testing::InSequence;
 using ::testing::Return;
 using ::testing::SetArgumentPointee;
+using ::testing::StrictMock;
 
 namespace media {
 
 // Fixture class to facilitate writing tests.  Takes care of setting up the
 // FFmpeg, pipeline and filter host mocks.
 class FFmpegDemuxerTest : public testing::Test {
  protected:
   // These constants refer to the stream ordering inside AVFormatContext.  We
   // simulate media with a data stream, audio stream and video stream.  Having
   // the data stream first forces the audio and video streams to get remapped
@@ skipping 572 matching lines @@
 
   // We shouldn't have freed the MP3 packet yet.
   MockFFmpeg::get()->CheckPoint(1);
 
   // Manually release the last reference to the buffer and verify it was freed.
   reader->Reset();
   WaitForDemuxerThread();
   MockFFmpeg::get()->CheckPoint(2);
 }
 
+// A mocked callback specialization for calling Read().  Since RunWithParams()
+// is mocked we don't need to pass in object or method pointers.
+typedef CallbackImpl<FFmpegDemuxerTest, void (FFmpegDemuxerTest::*)(Buffer*),
+                     Tuple1<Buffer*> > ReadCallback;
+class MockReadCallback : public ReadCallback {
+ public:
+  MockReadCallback()
+      : ReadCallback(NULL, NULL) {
+  }
+
+  virtual ~MockReadCallback() {
+    OnDelete();
+  }
+
+  MOCK_METHOD0(OnDelete, void());
+  MOCK_METHOD1(RunWithParams, void(const Tuple1<Buffer*>& params));
+};
+
+TEST_F(FFmpegDemuxerTest, Stop) {
+  // Tests that calling Read() on a stopped demuxer immediately deletes the
+  // callback.
+  {
+    SCOPED_TRACE("");
+    InitializeDemuxer();
+  }
+
+  // Create our mocked callback.  The demuxer will take ownership of this
+  // pointer.
+  scoped_ptr<StrictMock<MockReadCallback> > callback(
+      new StrictMock<MockReadCallback>());
+
+  // Get our stream.
+  scoped_refptr<DemuxerStream> audio = demuxer_->GetStream(DS_STREAM_AUDIO);
+  ASSERT_TRUE(audio);
+
+  // Stop the demuxer.
+  demuxer_->Stop();
+
+  // Expect all calls in sequence.
+  InSequence s;
+
+  // The callback should be immediately deleted.  We'll use a checkpoint to
+  // verify that it has indeed been deleted.
+  EXPECT_CALL(*callback, OnDelete());
+  EXPECT_CALL(*MockFFmpeg::get(), CheckPoint(1));
+
+  // Attempt the read...
+  audio->Read(callback.release());
+
+  // ...and verify that |callback| was deleted.
+  MockFFmpeg::get()->CheckPoint(1);
+}
+
 }  // namespace media