Issue 1310913004: Introduce composed tree version of inSameLine()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1310913004: Introduce composed tree version of inSameLine() (Closed)

Created:
5 years, 3 months ago by yosin_UTC9

Modified:
5 years, 3 months ago

Reviewers:
yoichio, hajimehoshi

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Introduce composed tree version of inSameLine() This patch introduces composed tree version of |inSameLine()| for introducing composed tree version of |VisibleSelection| class. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201868

Patch Set 1 : 2015-09-07T17:11:39 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -0 lines)			Patch
M	Source/core/editing/VisibleUnits.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/editing/VisibleUnits.cpp	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/editing/VisibleUnitsTest.cpp	View	2 chunks	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310913004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310913004/1

5 years, 3 months ago (2015-09-07 09:09:33 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-09-07 09:25:11 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201868

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages