Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: unittests/Bitcode/NaClParseTypesTest.cpp

Issue 1310883003: Install notion of diagnostic handler into PNaCl bitcode readers. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Patch Set: Fix issues in patch set 2. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « unittests/Bitcode/NaClParseInstsTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: unittests/Bitcode/NaClParseTypesTest.cpp
diff --git a/unittests/Bitcode/NaClParseTypesTest.cpp b/unittests/Bitcode/NaClParseTypesTest.cpp
index 605f7532764a44851869cf963fe6d2810bf29351..761ed4a5f1887de203d5f219c0eb5181009bdf0a 100644
--- a/unittests/Bitcode/NaClParseTypesTest.cpp
+++ b/unittests/Bitcode/NaClParseTypesTest.cpp
@@ -59,15 +59,10 @@ TEST(NaClParseTypesTest, BadTypeReferences) {
const uint64_t AddSelfReference[] = {
ReplaceIndex, NaClMungedBitcode::Replace, 3, 3, 1, Terminator
};
- EXPECT_FALSE(Munger.runTest(ARRAY(AddSelfReference), false));
- EXPECT_EQ(
- "Error: Record doesn't have expected size or structure\n",
- Munger.getTestResults());
- EXPECT_FALSE(Munger.runTest(ARRAY(AddSelfReference), true));
- EXPECT_EQ(
- "Error(40:2): Invalid TYPE_CODE_FLOAT record\n"
- "Error: Record doesn't have expected size or structure\n",
- Munger.getTestResults());
+ EXPECT_FALSE(Munger.runTest(ARRAY(AddSelfReference)));
+ EXPECT_EQ("Invalid TYPE_CODE_FLOAT record\n"
+ "Corrupted bitcode\n",
+ stripErrorPrefix(Munger.getTestResults()));
}
} // end of namespace naclmungetest
« no previous file with comments | « unittests/Bitcode/NaClParseInstsTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698