Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: tools/llvm-dis/llvm-dis.cpp

Issue 1310883003: Install notion of diagnostic handler into PNaCl bitcode readers. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Patch Set: Fix issues in patch set 2. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/NaCl/Bitcode/pnacl-bcdis/invalid.test ('k') | tools/pnacl-abicheck/pnacl-abicheck.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/llvm-dis/llvm-dis.cpp
diff --git a/tools/llvm-dis/llvm-dis.cpp b/tools/llvm-dis/llvm-dis.cpp
index dbf0c9c7b3c3440f4fddc91b550ebef9189ee1fd..86060e38a091b035e345209a17b333652a4412fe 100644
--- a/tools/llvm-dis/llvm-dis.cpp
+++ b/tools/llvm-dis/llvm-dis.cpp
@@ -188,9 +188,10 @@ int main(int argc, char **argv) {
break;
}
case PNaClFormat: {
+ DiagnosticHandlerFunction DiagnosticHandler = nullptr;
M.reset(getNaClStreamedBitcodeModule(
- DisplayFilename, Buffer.release(), Context, &errs(),
- &ErrorMessage));
+ DisplayFilename, Buffer.release(), Context,
+ /* DiagnosticHandler = */ nullptr, &ErrorMessage));
if(M.get()) {
if (std::error_code EC = M->materializeAllPermanently()) {
FoundErrors = true;
« no previous file with comments | « test/NaCl/Bitcode/pnacl-bcdis/invalid.test ('k') | tools/pnacl-abicheck/pnacl-abicheck.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698