test/NaCl/Bitcode/invalid.test - Issue 1310883003: Install notion of diagnostic handler into PNaCl bitcode readers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/NaCl/Bitcode/invalid.test

Issue 1310883003: Install notion of diagnostic handler into PNaCl bitcode readers. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master

Patch Set: Fix issues in patch set 2. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/NaCl/Bitcode/invalid.test

diff --git a/test/NaCl/Bitcode/invalid.test b/test/NaCl/Bitcode/invalid.test

index ab54c9d0f19a0b1ce74a5ae857c9acb7cd21b24c..892fa22740a6db71829caf1614bcfdfdce1dfb70 100644

--- a/test/NaCl/Bitcode/invalid.test

+++ b/test/NaCl/Bitcode/invalid.test

@@ -14,7 +14,7 @@ BAD-BC-BR-CMP: br i32 %p0, label %b1, label %b2;

BAD-BC-BR-CMP-NEXT: Branch condition not i1

RUN: pnacl-bcfuzz -bitcode-as-text %p/Inputs/bad-branch-compare.tbc \

-RUN: -output - | not pnacl-thaw -verbose-parse-errors -o /dev/null 2>&1 \

+RUN: -output - | not pnacl-thaw -o /dev/null 2>&1 \

RUN: | FileCheck --check-prefix=BAD-BR-CMP %s

BAD-BR-CMP: Type of branch condition not i1. Found: i32

« no previous file with comments | « lib/IRReader/IRReader.cpp ('k') | test/NaCl/Bitcode/pnacl-bcdis/invalid.test » ('j') | no next file with comments »