lib/Bitcode/NaCl/TestUtils/NaClBitcodeTextReader.cpp - Issue 1310883003: Install notion of diagnostic handler into PNaCl bitcode readers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/Bitcode/NaCl/TestUtils/NaClBitcodeTextReader.cpp

Issue 1310883003: Install notion of diagnostic handler into PNaCl bitcode readers. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master

Patch Set: Fix issues in patch set 2. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/Bitcode/NaCl/TestUtils/NaClBitcodeTextReader.cpp

diff --git a/lib/Bitcode/NaCl/TestUtils/NaClBitcodeTextReader.cpp b/lib/Bitcode/NaCl/TestUtils/NaClBitcodeTextReader.cpp

index 720e89455ce71732b12adcf48af4a20c3c66b42d..016f9d88031f119fc34a099efbd1b7e72980a7ef 100644

--- a/lib/Bitcode/NaCl/TestUtils/NaClBitcodeTextReader.cpp

+++ b/lib/Bitcode/NaCl/TestUtils/NaClBitcodeTextReader.cpp

@@ -287,5 +287,6 @@ llvm::parseNaClBitcodeText(const std::string &Filename, LLVMContext &Context,

// Parse buffer as ordinary binary bitcode file.

StringRef BitcodeBuffer(Buffer.data(), Buffer.size());

MemoryBufferRef MemBufRef(BitcodeBuffer, Filename);

- return NaClParseBitcodeFile(MemBufRef, Context, Verbose);

+ DiagnosticHandlerFunction DiagnosticHandler = nullptr;

+ return NaClParseBitcodeFile(MemBufRef, Context, DiagnosticHandler, Verbose);

}

« no previous file with comments | « lib/Bitcode/NaCl/TestUtils/NaClBitcodeMunge.cpp ('k') | lib/IRReader/IRReader.cpp » ('j') | no next file with comments »