lib/Bitcode/NaCl/TestUtils/NaClBitcodeMunge.cpp - Issue 1310883003: Install notion of diagnostic handler into PNaCl bitcode readers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/Bitcode/NaCl/TestUtils/NaClBitcodeMunge.cpp

Issue 1310883003: Install notion of diagnostic handler into PNaCl bitcode readers. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master

Patch Set: Reformat and fix nits. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« lib/Bitcode/NaCl/Reader/NaClBitcodeReader.cpp ('K') | « lib/Bitcode/NaCl/Reader/NaClBitcodeReader.cpp ('k') | lib/Bitcode/NaCl/TestUtils/NaClBitcodeTextReader.cpp » ('j') | tools/llvm-dis/llvm-dis.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/Bitcode/NaCl/TestUtils/NaClBitcodeMunge.cpp

diff --git a/lib/Bitcode/NaCl/TestUtils/NaClBitcodeMunge.cpp b/lib/Bitcode/NaCl/TestUtils/NaClBitcodeMunge.cpp

index 0d5e70c583062ed841a96be3ace1efb7c4cd4539..ff347f7eefa47db723f879b1ff5fb3b7085fbe65 100644

--- a/lib/Bitcode/NaCl/TestUtils/NaClBitcodeMunge.cpp

+++ b/lib/Bitcode/NaCl/TestUtils/NaClBitcodeMunge.cpp

@@ -141,11 +141,9 @@ bool NaClParseBitcodeMunger::runTest(const uint64_t Munges[], size_t MungesSize,

return cleanupTest();

LLVMContext &Context = getGlobalContext();

- raw_ostream *VerboseStrm = VerboseErrors ? &getDumpStream() : nullptr;

ErrorOr<Module *> ModuleOrError =

NaClParseBitcodeFile(MungedInput->getMemBufferRef(), Context,

- VerboseStrm);

+ redirectNaClDiagnosticToStream(getDumpStream()));

if (ModuleOrError) {

if (VerboseErrors)

getDumpStream() << "Successful parse!\n";