Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 1310873004: Include additional translation in getBBox for SVGUseElement (Closed)

Created:
5 years, 3 months ago by fs
Modified:
5 years, 3 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Include additional translation in getBBox for SVGUseElement LayoutObject::objectBoundingBox() can't be used, because the additional translation is included in the local-to-parent transform. BUG=512081 Committed: https://crrev.com/495b0fc68f462f3541919a38a15eed0d8fea6878 git-svn-id: svn://svn.chromium.org/blink/trunk@202136 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
A LayoutTests/svg/custom/getBBox-use.html View 1 chunk +16 lines, -0 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGTransformableContainer.h View 2 chunks +4 lines, -0 lines 1 comment Download
M Source/core/svg/SVGUseElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
fs
https://codereview.chromium.org/1317563010/ should be allowed to land first since this would otherwise affect the result of ...
5 years, 3 months ago (2015-09-08 15:34:59 UTC) #2
fs
On 2015/09/08 15:34:59, fs wrote: > https://codereview.chromium.org/1317563010/ should be allowed to land first > since ...
5 years, 3 months ago (2015-09-10 10:41:46 UTC) #3
pdr.
LGTM https://codereview.chromium.org/1310873004/diff/1/Source/core/layout/svg/LayoutSVGTransformableContainer.h File Source/core/layout/svg/LayoutSVGTransformableContainer.h (right): https://codereview.chromium.org/1310873004/diff/1/Source/core/layout/svg/LayoutSVGTransformableContainer.h#newcode37 Source/core/layout/svg/LayoutSVGTransformableContainer.h:37: const FloatSize& additionalTranslation() const { return m_lastTranslation; } ...
5 years, 3 months ago (2015-09-11 05:57:19 UTC) #4
fs
On 2015/09/11 05:57:19, pdr wrote: ... > https://codereview.chromium.org/1310873004/diff/1/Source/core/layout/svg/LayoutSVGTransformableContainer.h > File Source/core/layout/svg/LayoutSVGTransformableContainer.h (right): > > https://codereview.chromium.org/1310873004/diff/1/Source/core/layout/svg/LayoutSVGTransformableContainer.h#newcode37 ...
5 years, 3 months ago (2015-09-11 07:40:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310873004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310873004/1
5 years, 3 months ago (2015-09-11 07:41:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/102704)
5 years, 3 months ago (2015-09-11 09:15:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310873004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310873004/1
5 years, 3 months ago (2015-09-11 10:32:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/102747)
5 years, 3 months ago (2015-09-11 11:55:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310873004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310873004/1
5 years, 3 months ago (2015-09-11 13:08:50 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202136
5 years, 3 months ago (2015-09-11 14:02:48 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:22:12 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/495b0fc68f462f3541919a38a15eed0d8fea6878

Powered by Google App Engine
This is Rietveld 408576698