Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1310863005: [arm] Decrease the size of the assembler class by allocating buffers of pending constants on the he… (Closed)

Created:
5 years, 3 months ago by Igor Sheludko
Modified:
5 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Decrease the size of the assembler class by allocating buffers of pending constants on the heap. BUG=chromium:521828 LOG=N Committed: https://crrev.com/ce751ccf1ec2cc3765ef7031d107f5a22300f43a Cr-Commit-Position: refs/heads/master@{#30602}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
M src/arm/assembler-arm.h View 2 chunks +5 lines, -2 lines 0 comments Download
M src/arm/assembler-arm.cc View 4 chunks +26 lines, -0 lines 0 comments Download
M src/ic/access-compiler.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Igor Sheludko
PTAL, on arm64 the MacroAssembler happened to be 560 bytes.
5 years, 3 months ago (2015-09-04 16:41:20 UTC) #2
Jakob Kummerow
lgtm
5 years, 3 months ago (2015-09-04 18:24:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310863005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310863005/1
5 years, 3 months ago (2015-09-05 08:52:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-05 08:53:50 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-05 08:54:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce751ccf1ec2cc3765ef7031d107f5a22300f43a
Cr-Commit-Position: refs/heads/master@{#30602}

Powered by Google App Engine
This is Rietveld 408576698