Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: runtime/observatory/tests/service/test_helper.dart

Issue 1310863004: More logging for pause tests (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/pause_on_start_then_step_test.dart ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/test_helper.dart
diff --git a/runtime/observatory/tests/service/test_helper.dart b/runtime/observatory/tests/service/test_helper.dart
index 89d35febe6d0732d0dbfbda6ee5b24a333f748db..6c6c223bdfacbd4e46e1ce522c49cfb4a4c032f4 100644
--- a/runtime/observatory/tests/service/test_helper.dart
+++ b/runtime/observatory/tests/service/test_helper.dart
@@ -109,7 +109,8 @@ void runIsolateTests(List<String> mainArgs,
void testeeConcurrent(),
bool pause_on_start: false,
bool pause_on_exit: false,
- bool trace_service: false}) {
+ bool trace_service: false,
+ bool verbose_vm: false}) {
assert(!pause_on_start || testeeBefore == null);
if (mainArgs.contains(_TESTEE_MODE_FLAG)) {
if (!pause_on_start) {
@@ -140,6 +141,7 @@ void runIsolateTests(List<String> mainArgs,
new WebSocketVM(new WebSocketVMTarget(addr)).load()
.then((VM vm) => vm.isolates.first.load())
.then((Isolate isolate) => Future.forEach(tests, (test) {
+ isolate.vm.verbose = verbose_vm;
print('Running $name [$testIndex/$totalTests]');
testIndex++;
return test(isolate);
@@ -285,7 +287,8 @@ Future runVMTests(List<String> mainArgs,
Future testeeConcurrent(),
bool pause_on_start: false,
bool pause_on_exit: false,
- bool trace_service: false}) async {
+ bool trace_service: false,
+ bool verbose_vm: false}) async {
if (mainArgs.contains(_TESTEE_MODE_FLAG)) {
if (!pause_on_start) {
if (testeeBefore != null) {
@@ -316,6 +319,7 @@ Future runVMTests(List<String> mainArgs,
runZoned(() {
new WebSocketVM(new WebSocketVMTarget(addr)).load()
.then((VM vm) => Future.forEach(tests, (test) {
+ vm.verbose = verbose_vm;
print('Running $name [$testIndex/$totalTests]');
testIndex++;
return test(vm);
« no previous file with comments | « runtime/observatory/tests/service/pause_on_start_then_step_test.dart ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698