Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1310863004: More logging for pause tests (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/tests/service/pause_on_start_and_exit_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 8907a8ee84bd9392396a4f07d37153033e679645..5cf96c56e3248ac6e123d7918c6f959c51c4caa8 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -514,6 +514,9 @@ abstract class VM extends ServiceObjectOwner {
// TODO(turnidge): The connection should not be stored in the VM object.
bool get isDisconnected;
+ // Used for verbose logging.
+ bool verbose = false;
+
// TODO(johnmccutchan): Ensure that isolates do not end up in _cache.
Map<String,ServiceObject> _cache = new Map<String,ServiceObject>();
final ObservableMap<String,Isolate> _isolateCache =
@@ -1281,6 +1284,9 @@ class Isolate extends ServiceObjectOwner with Coverage {
exceptionsPauseInfo = map['_debuggerSettings']['_exceptions'];
pauseEvent = map['pauseEvent'];
+ if (vm.verbose) {
+ print('VM-VERBOSE: $name reloaded. pause event= $pauseEvent');
+ }
_updateRunState();
error = map['error'];
@@ -1332,6 +1338,9 @@ class Isolate extends ServiceObjectOwner with Coverage {
}
void _onEvent(ServiceEvent event) {
+ if (vm.verbose) {
+ print('VM-VERBOSE: $name _onEvent $event');
+ }
switch(event.kind) {
case ServiceEvent.kIsolateStart:
case ServiceEvent.kIsolateRunnable:
@@ -1361,6 +1370,7 @@ class Isolate extends ServiceObjectOwner with Coverage {
case ServiceEvent.kPauseException:
case ServiceEvent.kResume:
pauseEvent = event;
+ print('VM-VERBOSE: $name pause event $pauseEvent');
_updateRunState();
break;
« no previous file with comments | « no previous file | runtime/observatory/tests/service/pause_on_start_and_exit_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698