Source/devtools/front_end/ui/Tooltip.js - Issue 1310863003: Devtools UI: Tooltip needs to consider tooltip height in placing tooltip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/ui/Tooltip.js

Issue 1310863003: Devtools UI: Tooltip needs to consider tooltip height in placing tooltip (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/ui/Tooltip.js

diff --git a/Source/devtools/front_end/ui/Tooltip.js b/Source/devtools/front_end/ui/Tooltip.js

index 9a942801937eaab6053ab296c06bd97a260ee820..b48c7e02419b2576f6f6f7309dfd3e20befc688e 100644

--- a/Source/devtools/front_end/ui/Tooltip.js

+++ b/Source/devtools/front_end/ui/Tooltip.js

@@ -101,7 +101,7 @@ WebInspector.Tooltip.prototype = {

tooltipX = Number.constrain(tooltipX,

containerOffset.x + pageMargin,

containerOffset.x + containerOffsetWidth - tooltipWidth - pageMargin);

- var onBottom = anchorBox.y + anchorOffset + anchorBox.height < containerOffset.y + containerOffsetHeight;

+ var onBottom = anchorBox.y + anchorOffset + anchorBox.height + tooltipHeight < containerOffset.y + containerOffsetHeight;

var tooltipY = onBottom ? anchorBox.y + anchorBox.height + anchorOffset : anchorBox.y - tooltipHeight - anchorOffset;

this._tooltipElement.positionAt(tooltipX, tooltipY);

« no previous file with comments | « no previous file | no next file » | no next file with comments »