Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1310853004: Drop Hixie76 support from WebSocketServer. (Closed)

Created:
5 years, 3 months ago by yhirano
Modified:
5 years, 3 months ago
Reviewers:
dgozman, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop Hixie76 support from WebSocketServer. BUG=523228 Committed: https://crrev.com/995e9645c3e1116545cc0681cd26de8db4c75c67 Cr-Commit-Position: refs/heads/master@{#347863}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -226 lines) Patch
M net/server/web_socket.h View 3 chunks +15 lines, -8 lines 0 comments Download
M net/server/web_socket.cc View 2 chunks +61 lines, -218 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
yhirano
5 years, 3 months ago (2015-09-09 01:52:01 UTC) #2
dgozman
lgtm
5 years, 3 months ago (2015-09-09 02:12:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310853004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310853004/1
5 years, 3 months ago (2015-09-09 02:15:50 UTC) #5
yhirano
+mmenke as an owner.
5 years, 3 months ago (2015-09-09 02:33:39 UTC) #8
mmenke
On 2015/09/09 02:33:39, yhirano wrote: > +mmenke as an owner. LGTM, rubberstamp
5 years, 3 months ago (2015-09-09 05:30:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310853004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310853004/1
5 years, 3 months ago (2015-09-09 06:12:21 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 09:01:26 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 09:02:30 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/995e9645c3e1116545cc0681cd26de8db4c75c67
Cr-Commit-Position: refs/heads/master@{#347863}

Powered by Google App Engine
This is Rietveld 408576698