Various minor cross-platform changes

Various minor cross-platform changes

Committed: https://skia.googlesource.com/skia/+/2dc29940c54b5d21c81dade8a7755dd08316b6b3

[jvanverth1, 2015-08-31 19:28:05]

jvanverth@google.com changed reviewers:
+ bsalomon@google.com, egdaniel@google.com

[bsalomon, 2015-08-31 19:34:02]

On 2015/08/31 19:28:05, jvanverth1 wrote:

lgtm

[egdaniel, 2015-08-31 19:37:06]

lgtm with removal on added line in gyp file

https://codereview.chromium.org/1310843007/diff/1/gyp/tests.gypi
File gyp/tests.gypi (right):

https://codereview.chromium.org/1310843007/diff/1/gyp/tests.gypi#newcode55
gyp/tests.gypi:55: '<!@(python find.py ../../tests "*.c*")',
you can simply use the skia_gpu_extra_tests_path above, and thus shouldn't need
this line

[jvanverth1, 2015-09-01 13:37:30]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2015-09-01 13:37:31]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com,
egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1310843007/#ps20001
(title: "Remove gyp change")

[commit-bot: I haz the power, 2015-09-01 13:37:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1310843007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1310843007/20001

[commit-bot: I haz the power, 2015-09-01 13:38:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-01 13:38:19]

Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[jvanverth1, 2015-09-01 14:12:06]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2015-09-01 14:12:06]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com,
egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1310843007/#ps20002
(title: "Update to ToT")

[commit-bot: I haz the power, 2015-09-01 14:12:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1310843007/20002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1310843007/20002

[commit-bot: I haz the power, 2015-09-01 14:16:49]

Committed patchset #3 (id:20002) as
https://skia.googlesource.com/skia/+/2dc29940c54b5d21c81dade8a7755dd08316b6b3