Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: public/web/modules/serviceworker/WebServiceWorkerContextClient.h

Issue 1310843006: Pass the v8::Context through the willDestroyServiceWorkerContextOnWorkerThread event. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/ServiceWorkerGlobalScopeProxy.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/modules/serviceworker/WebServiceWorkerContextClient.h
diff --git a/public/web/modules/serviceworker/WebServiceWorkerContextClient.h b/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
index 10a586a2fb0f869cd61bc14a8a100eff2e82fd35..8421a65a98b1a9af5e016dc60c459e536ab9da16 100644
--- a/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
+++ b/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
@@ -79,7 +79,12 @@ public:
// WorkerGlobalScope is about to be destroyed. The client should clear
// the WebServiceWorkerGlobalScopeProxy when this is called.
- virtual void willDestroyWorkerContext() { }
+ virtual void willDestroyWorkerContext(v8::Local<v8::Context> context)
+ {
+ willDestroyWorkerContext();
+ }
+ // TODO(kalman): Remove after Chromium-side patch lands.
+ virtual void willDestroyWorkerContext() {}
// WorkerGlobalScope is destroyed and the worker is ready to be terminated.
virtual void workerContextDestroyed() { }
« no previous file with comments | « Source/web/ServiceWorkerGlobalScopeProxy.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698