Issue 131080: Linux: make import warning dialog modal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131080: Linux: make import warning dialog modal. (Closed)

Created:
11 years, 6 months ago by kuchhal

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Linux: make import warning dialog modal. Make ImporterHost aware of the current parent window and use that as parent for the warning dialog. BUG=13481 TEST=Start Firefox, try to import profile in Chrome and make sure the warning dialog is modal.

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -3 lines)			Patch
M	chrome/browser/gtk/import_dialog_gtk.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/gtk/import_progress_dialog_gtk.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/importer/importer.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/importer/importer.cc	View	3 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm, thanks for doing this

Expand Messages | Collapse Messages