Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 1310773006: Update sandbox/linux from upstream (Closed)

Created:
5 years, 4 months ago by jln (very slow on Chromium)
Modified:
5 years, 4 months ago
Reviewers:
jamesr, mdempsky
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
ssh://ssh.github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Update sandbox/linux/ from https://crrev.com/344610 Pull sandbox changes from upstream, up to https://crrev.com/344610 This mostly include fixes and cleanups, including for a complex TLS corruption issue fixed in crbug.com/512623 This required a minimal workaround to work with the older version of base/ of Mojo. R=jamesr@chromium.org, mdempsky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/06f35a69f16372fb4f7953f0b83e16725db517de

Patch Set 1 #

Patch Set 2 : Update to 3909ebfa69566f7374a6900e63cd4d3c73a35378 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+763 lines, -692 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/linux/BUILD.gn View 1 4 chunks +15 lines, -3 lines 0 comments Download
M sandbox/linux/bpf_dsl/DEPS View 1 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl.h View 1 3 chunks +7 lines, -3 lines 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl.cc View 1 4 chunks +21 lines, -8 lines 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl_impl.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc View 1 7 chunks +40 lines, -63 lines 0 comments Download
A + sandbox/linux/bpf_dsl/errorcode.h View 1 5 chunks +17 lines, -15 lines 0 comments Download
A + sandbox/linux/bpf_dsl/errorcode.cc View 1 7 chunks +19 lines, -14 lines 0 comments Download
A sandbox/linux/bpf_dsl/errorcode_unittest.cc View 1 1 chunk +120 lines, -0 lines 0 comments Download
M sandbox/linux/bpf_dsl/policy_compiler.h View 1 4 chunks +11 lines, -1 line 0 comments Download
M sandbox/linux/bpf_dsl/policy_compiler.cc View 1 7 chunks +15 lines, -6 lines 0 comments Download
M sandbox/linux/bpf_dsl/seccomp_macros.h View 1 chunk +1 line, -2 lines 0 comments Download
A sandbox/linux/bpf_dsl/test_trap_registry.h View 1 1 chunk +37 lines, -0 lines 0 comments Download
A sandbox/linux/bpf_dsl/test_trap_registry.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
A sandbox/linux/bpf_dsl/test_trap_registry_unittest.cc View 1 1 chunk +48 lines, -0 lines 0 comments Download
M sandbox/linux/bpf_dsl/verifier.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M sandbox/linux/sandbox_linux.gypi View 1 3 chunks +4 lines, -3 lines 0 comments Download
M sandbox/linux/sandbox_linux_nacl_nonsfi.gyp View 1 2 chunks +1 line, -1 line 0 comments Download
M sandbox/linux/sandbox_linux_test_sources.gypi View 1 1 chunk +4 lines, -1 line 0 comments Download
D sandbox/linux/seccomp-bpf/errorcode.h View 1 1 chunk +0 lines, -203 lines 0 comments Download
D sandbox/linux/seccomp-bpf/errorcode.cc View 1 1 chunk +0 lines, -115 lines 0 comments Download
D sandbox/linux/seccomp-bpf/errorcode_unittest.cc View 1 1 chunk +0 lines, -120 lines 0 comments Download
M sandbox/linux/seccomp-bpf/sandbox_bpf.cc View 1 4 chunks +10 lines, -6 lines 0 comments Download
M sandbox/linux/services/credentials.h View 1 chunk +3 lines, -0 lines 0 comments Download
M sandbox/linux/services/credentials.cc View 3 chunks +36 lines, -3 lines 0 comments Download
M sandbox/linux/services/credentials_unittest.cc View 2 chunks +27 lines, -0 lines 0 comments Download
M sandbox/linux/services/namespace_sandbox.h View 4 chunks +7 lines, -5 lines 0 comments Download
M sandbox/linux/services/namespace_sandbox.cc View 7 chunks +16 lines, -9 lines 0 comments Download
M sandbox/linux/services/namespace_sandbox_unittest.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M sandbox/linux/services/proc_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/services/scoped_process_unittest.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M sandbox/linux/services/syscall_wrappers.cc View 3 chunks +23 lines, -26 lines 0 comments Download
M sandbox/linux/services/thread_helpers.h View 1 chunk +7 lines, -3 lines 0 comments Download
M sandbox/linux/services/thread_helpers.cc View 6 chunks +64 lines, -21 lines 0 comments Download
M sandbox/linux/services/thread_helpers_unittests.cc View 4 chunks +10 lines, -5 lines 0 comments Download
M sandbox/linux/services/yama_unittests.cc View 3 chunks +5 lines, -5 lines 0 comments Download
A sandbox/linux/syscall_broker/broker_host_unittests.cc View 1 chunk +42 lines, -0 lines 0 comments Download
M sandbox/linux/system_headers/linux_signal.h View 4 chunks +99 lines, -28 lines 0 comments Download
M sandbox/linux/tests/unit_tests.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
jln (very slow on Chromium)
mdempsky: could you take a quick look? I'm rolling upstream Bauxite to Mojo. The only ...
5 years, 4 months ago (2015-08-22 00:13:43 UTC) #2
mdempsky
lgtm Looks like difference is GetThreadId vs thread_id? For future rolls, it might be easier ...
5 years, 4 months ago (2015-08-22 01:33:36 UTC) #3
jln (very slow on Chromium)
On 2015/08/22 01:33:36, mdempsky wrote: > lgtm Thanks! > Looks like difference is GetThreadId vs ...
5 years, 4 months ago (2015-08-22 01:36:42 UTC) #4
jln (very slow on Chromium)
James, do you mind rubberstamping this? Next time, should I just commit if it only ...
5 years, 4 months ago (2015-08-22 01:37:23 UTC) #6
jln (very slow on Chromium)
(This message is sent from the chromium.org origin to see if it makes a difference)
5 years, 4 months ago (2015-08-22 16:55:19 UTC) #7
jamesr
lgtm in the future if you're pulling in changes from chromium (or wherever) to sandbox/ ...
5 years, 4 months ago (2015-08-24 17:27:39 UTC) #8
jamesr
Also as a style matter whenever pulling from chromium I'd recommend putting an https://crrev.com/{commit position} ...
5 years, 4 months ago (2015-08-24 17:29:10 UTC) #9
jln (very slow on Chromium)
On 2015/08/24 17:29:10, jamesr wrote: > Also as a style matter whenever pulling from chromium ...
5 years, 4 months ago (2015-08-24 17:38:36 UTC) #10
jln (very slow on Chromium)
5 years, 4 months ago (2015-08-24 17:42:13 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
06f35a69f16372fb4f7953f0b83e16725db517de (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698