Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1310753007: Run tests on Chrome stable and canary (Closed)

Created:
5 years, 3 months ago by vsm
Modified:
5 years, 3 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Run tests on Chrome stable and canary As of Chrome 45, we can run on stable and canary. Karma appears to run these in parallel - I see little difference in wall clock time on my laptop. R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/42448e4618c9bd54f09553dbdf100899cc8cf683

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M karma.conf.js View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
vsm
5 years, 3 months ago (2015-09-09 23:20:50 UTC) #2
Jennifer Messerly
lgtm
5 years, 3 months ago (2015-09-10 16:11:38 UTC) #3
vsm
5 years, 3 months ago (2015-09-10 16:14:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
42448e4618c9bd54f09553dbdf100899cc8cf683 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698