Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5948)

Unified Diff: chrome/renderer/page_load_histograms.cc

Issue 1310743003: Consistently use LoFi for an entire page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_histograms.cc
diff --git a/chrome/renderer/page_load_histograms.cc b/chrome/renderer/page_load_histograms.cc
index 0a96e42d055e81418cd21537bbdf27681c05664a..78bb3180816abf7eaf1c9a4b947c6d6406b12b40 100644
--- a/chrome/renderer/page_load_histograms.cc
+++ b/chrome/renderer/page_load_histograms.cc
@@ -909,12 +909,15 @@ void PageLoadHistograms::Dump(WebFrame* frame) {
MaybeDumpFirstLayoutHistograms();
+ content::RenderFrame* render_frame =
+ content::RenderFrame::FromWebFrame(frame);
bengr 2015/10/20 16:30:51 It looks like this can return null, but then you u
megjablon 2015/10/20 17:46:35 Done.
+
// Metrics based on the timing information recorded for the Navigation Timing
// API - http://www.w3.org/TR/navigation-timing/.
- DumpHistograms(
- frame->performance(), document_state, data_reduction_proxy_was_used,
- false /* TODO: render_frame->IsUsingLoFi() */, came_from_websearch,
- websearch_chrome_joint_experiment_id, is_preview, scheme_type);
+ DumpHistograms(frame->performance(), document_state,
+ data_reduction_proxy_was_used, render_frame->IsUsingLoFi(),
+ came_from_websearch, websearch_chrome_joint_experiment_id,
+ is_preview, scheme_type);
// Old metrics based on the timing information stored in DocumentState. These
// are deprecated and should go away.

Powered by Google App Engine
This is Rietveld 408576698