Consistently use LoFi for an entire page

content/browser/loader/resource_dispatcher_host_impl.cc

Index: content/browser/loader/resource_dispatcher_host_impl.cc
diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc
index 2d7512b63ae834050f1393383a7b88a9a5eedd4e..d6fc29c2ba0ca7040a4c7e6527b47db6f0561856 100644
--- a/content/browser/loader/resource_dispatcher_host_impl.cc
+++ b/content/browser/loader/resource_dispatcher_host_impl.cc
@@ -1322,6 +1322,16 @@ void ResourceDispatcherHostImpl::BeginRequest(
   }
   new_request->SetLoadFlags(load_flags);
 
+  bool is_using_lofi;
+  if (request_data.lofi_state == LOFI_UNSPECIFIED && delegate_) {
+    is_using_lofi =
+        delegate_->ShouldEnableLoFiMode(new_request.get(), resource_context);
+  } else if (request_data.lofi_state == LOFI_ON) {
+    is_using_lofi = true;
+  } else {
+    is_using_lofi = false;
+  }

[nasko, 2015/10/15 16:54:43]

Since this identical code is used in two places in this file, why not pull it
into a helper function in the anonymous namespace and call it from both places? 
You can even call inlined in the constructor belo, since it will just return a
boolean and you can save yourself declaring a local variable.

[megjablon, 2015/10/19 22:13:49]

Done.

+
   // Make extra info and read footer (contains request ID).
   ResourceRequestInfoImpl* extra_info = new ResourceRequestInfoImpl(
       process_type, child_id, route_id,
@@ -1346,7 +1356,8 @@ void ResourceDispatcherHostImpl::BeginRequest(
       request_data.visiblity_state,
       resource_context, filter_->GetWeakPtr(),
       report_raw_headers,
-      !is_sync_load);
+      !is_sync_load,
+      is_using_lofi);
   // Request takes ownership.
   extra_info->AssociateWithRequest(new_request.get());
 
@@ -1632,7 +1643,8 @@ ResourceRequestInfoImpl* ResourceDispatcherHostImpl::CreateRequestInfo(
       context,
       base::WeakPtr<ResourceMessageFilter>(),  // filter
       false,                                   // report_raw_headers
-      true);                                   // is_async
+      true,                                    // is_async
+      false);                                  // is_using_lofi
 }
 
 void ResourceDispatcherHostImpl::OnRenderViewHostCreated(int child_id,
@@ -2042,6 +2054,16 @@ void ResourceDispatcherHostImpl::BeginNavigationRequest(
 
   request_id_--;
 
+  bool is_using_lofi;
+  if (info.common_params.lofi_state == LOFI_UNSPECIFIED && delegate_) {
+    is_using_lofi =
+        delegate_->ShouldEnableLoFiMode(new_request.get(), resource_context);
+  } else if (info.common_params.lofi_state == LOFI_ON) {
+    is_using_lofi = true;
+  } else {
+    is_using_lofi = false;
+  }
+
   // Make extra info and read footer (contains request ID).
   //
   // TODO(davidben): Associate the request with the FrameTreeNode and/or tab so
@@ -2077,7 +2099,8 @@ void ResourceDispatcherHostImpl::BeginNavigationRequest(
       resource_context,
       base::WeakPtr<ResourceMessageFilter>(),  // filter
       false,  // request_data.report_raw_headers
-      true);
+      true,
+      is_using_lofi);
   // Request takes ownership.
   extra_info->AssociateWithRequest(new_request.get());