components/data_reduction_proxy/content/browser/content_lofi_decider.cc - Issue 1310743003: Consistently use LoFi for an entire page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/content/browser/content_lofi_decider.cc

Issue 1310743003: Consistently use LoFi for an entire page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test comment fixes Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/content/browser/content_data_reduction_proxy_lofi_helper.cc ('k') | content/browser/frame_host/navigation_controller_impl.h » ('j') | content/browser/loader/resource_dispatcher_host_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/content/browser/content_lofi_decider.cc

diff --git a/components/data_reduction_proxy/content/browser/content_lofi_decider.cc b/components/data_reduction_proxy/content/browser/content_lofi_decider.cc

index b7fb0e3e37dd45ff0b2f5e8289640ec78dd23526..3670ea9570e80c43c6de8b5b4cb3d27cb475329e 100644

--- a/components/data_reduction_proxy/content/browser/content_lofi_decider.cc

+++ b/components/data_reduction_proxy/content/browser/content_lofi_decider.cc

@@ -15,7 +15,11 @@ ContentLoFiDecider::ContentLoFiDecider() {}

ContentLoFiDecider::~ContentLoFiDecider() {}

bool ContentLoFiDecider::IsUsingLoFiMode(const net::URLRequest& request) const {

- // TODO: will be check of ResourceRequestInfo::IsUsingLoFi

+ const content::ResourceRequestInfo* request_info =

+ content::ResourceRequestInfo::ForRequest(&request);

+ if (request_info) {

+ return request_info->IsUsingLoFi();

+ }

mmenke 2015/10/13 15:42:49 nit: Remove braces

megjablon 2015/10/14 18:09:46 Done.

return false;

}