Consistently use LoFi for an entire page

content/browser/loader/resource_dispatcher_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
 
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
 
 #include <algorithm>
 #include <set>
@@ skipping 1304 matching lines @@
   // Sync loads should have maximum priority and should be the only
   // requets that have the ignore limits flag set.
   if (is_sync_load) {
     DCHECK_EQ(request_data.priority, net::MAXIMUM_PRIORITY);
     DCHECK_NE(load_flags & net::LOAD_IGNORE_LIMITS, 0);
   } else {
     DCHECK_EQ(load_flags & net::LOAD_IGNORE_LIMITS, 0);
   }
   new_request->SetLoadFlags(load_flags);
 
+  bool is_lofi;

[mmenke, 2015/09/29 16:35:57]

Maybe is_lofi -> use_lofi / using_lofi / is_using_lofi?  modifies a bunch of
files, but think it's clearer.  "This request uses lofi" seems clearer than
"this request is lofi" to me.

[megjablon, 2015/09/29 21:20:07]

Done.

+  if (request_data.lofi_state == LOFI_DEFAULT &&

[mmenke, 2015/09/29 16:35:57]

I think this code makes more sense if LOFI_DEFAULT is renamed to
LOFI_UNSPECIFIED.  "Default" implies a single default value, but we're letting
the delegate set it on a per-request basis, rather than using a default value.

[megjablon, 2015/09/29 21:20:07]

Done.

+      (load_flags & net::LOAD_MAIN_FRAME) != 0 && delegate_) {

[mmenke, 2015/09/29 16:35:57]

I don't see why we shouldn't call into the delegate on non-main frames, when
lofi_state is is LOFI_DEFAULT.

[megjablon, 2015/09/29 21:20:07]

Done.

+    is_lofi = delegate_->ShouldEnableLoFiMode(new_request.get(),
+                                              resource_context);
+  } else if (request_data.lofi_state == LOFI_ON) {
+    is_lofi = true;
+  } else {
+    is_lofi = false;

[mmenke, 2015/09/29 16:35:57]

Question:  Do favicons also inherit the lofi bit from the main page?  That may
be problematic, if they're shared via sync.

[megjablon, 2015/09/29 21:20:07]

The proxy has logic so that icons and button images aren't "LoFi-ed". Testing it
out, I haven't seen a favicon that got the placeholder, but I'll have to ask if
favicons are explicitly filtered out or if they just happen to be detected by
the logic that finds icons.

+  }
+
   // Make extra info and read footer (contains request ID).
   ResourceRequestInfoImpl* extra_info = new ResourceRequestInfoImpl(
       process_type, child_id, route_id,
       -1,  // frame_tree_node_id
       request_data.origin_pid,
       request_id,
       request_data.render_frame_id,
       request_data.is_main_frame,
       request_data.parent_is_main_frame,
       request_data.parent_render_frame_id,
       request_data.resource_type,
       request_data.transition_type,
       request_data.should_replace_current_entry,
       false,  // is download
       false,  // is stream
       allow_download,
       request_data.has_user_gesture,
       request_data.enable_load_timing,
       request_data.enable_upload_progress,
       do_not_prompt_for_login,
       request_data.referrer_policy,
       request_data.visiblity_state,
       resource_context, filter_->GetWeakPtr(),
       report_raw_headers,
-      !is_sync_load);
+      !is_sync_load,
+      is_lofi);
   // Request takes ownership.
   extra_info->AssociateWithRequest(new_request.get());
 
   if (new_request->url().SchemeIs(url::kBlobScheme)) {
     // Hang on to a reference to ensure the blob is not released prior
     // to the job being started.
     storage::BlobProtocolHandler::SetRequestedBlobDataHandle(
         new_request.get(),
         filter_->blob_storage_context()->context()->GetBlobDataFromPublicURL(
             new_request->url()));
@@ skipping 255 matching lines @@
       download,  // allow_download
       false,     // has_user_gesture
       false,     // enable_load_timing
       false,     // enable_upload_progress
       false,     // do_not_prompt_for_login
       blink::WebReferrerPolicyDefault,
       blink::WebPageVisibilityStateVisible,
       context,
       base::WeakPtr<ResourceMessageFilter>(),  // filter
       false,                                   // report_raw_headers
-      true);                                   // is_async
+      true,                                    // is_async
+      false);                                  // is_lofi
 }
 
 void ResourceDispatcherHostImpl::OnRenderViewHostCreated(int child_id,
                                                          int route_id,
                                                          bool is_visible,
                                                          bool is_audible) {
   scheduler_->OnClientCreated(child_id, route_id, is_visible, is_audible);
 }
 
 void ResourceDispatcherHostImpl::OnRenderViewHostDeleted(
@@ skipping 390 matching lines @@
     new_request->set_upload(UploadDataStreamBuilder::Build(
         info.request_body.get(),
         blob_context,
         nullptr,  // file_system_context
         BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE)
             .get()));
   }
 
   request_id_--;
 
+  bool is_lofi;
+  if (info.common_params.lofi_state == LOFI_DEFAULT && delegate_) {
+    is_lofi = delegate_->ShouldEnableLoFiMode(new_request.get(),
+                                              resource_context);
+  } else if (info.common_params.lofi_state == LOFI_ON) {
+    is_lofi = true;
+  } else {
+    is_lofi = false;
+  }
+
   // Make extra info and read footer (contains request ID).
   //
   // TODO(davidben): Associate the request with the FrameTreeNode and/or tab so
   // that IO thread -> UI thread hops will work.
   ResourceRequestInfoImpl* extra_info = new ResourceRequestInfoImpl(
       PROCESS_TYPE_BROWSER,
       -1,  // child_id
       -1,  // route_id
       info.frame_tree_node_id,
       -1,  // request_data.origin_pid,
@@ skipping 15 matching lines @@
       false,  // enable_upload_progress
       false,  // do_not_prompt_for_login
       info.common_params.referrer.policy,
       // TODO(davidben): This is only used for prerenders. Replace
       // is_showing with something for that. Or maybe it just comes from the
       // same mechanism as the cookie one.
       blink::WebPageVisibilityStateVisible,
       resource_context,
       base::WeakPtr<ResourceMessageFilter>(),  // filter
       false,  // request_data.report_raw_headers
-      true);
+      true,
+      is_lofi);
   // Request takes ownership.
   extra_info->AssociateWithRequest(new_request.get());
 
   if (new_request->url().SchemeIs(url::kBlobScheme)) {
     // Hang on to a reference to ensure the blob is not released prior
     // to the job being started.
     ChromeBlobStorageContext* blob_context =
         GetChromeBlobStorageContextForResourceContext(resource_context);
     storage::BlobProtocolHandler::SetRequestedBlobDataHandle(
         new_request.get(),
@@ skipping 335 matching lines @@
     load_flags |= net::LOAD_PREFETCH;
   }
 
   if (is_sync_load)
     load_flags |= net::LOAD_IGNORE_LIMITS;
 
   return load_flags;
 }
 
 }  // namespace content