Consistently use LoFi for an entire page

net/url_request/url_request.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_H_
 #define NET_URL_REQUEST_URL_REQUEST_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 42 matching lines @@
 class UploadDataStream;
 class URLRequestContext;
 class URLRequestJob;
 class X509Certificate;
 
 // This stores the values of the Set-Cookie headers received during the request.
 // Each item in the vector corresponds to a Set-Cookie: line received,
 // excluding the "Set-Cookie:" part.
 typedef std::vector<std::string> ResponseCookies;
 
+// The LoFi state which determines whether to add the LoFi header. Must stay
+// in sync with the enum in navigation_params.h.
+enum LoFiState {
+  // Add the LoFi header to the request.
+  LOFI_ON = 0,
+  // Do not add the LoFi header to the request.
+  LOFI_OFF,
+  // Check with the network-quality-based triggering logic and add the header if

[bengr, 2015/08/25 00:00:02]

See my previous comment about not specifying the implementation.

[megjablon, 2015/08/25 20:29:47]

Done.

+  // the network is slow.
+  LOFI_DEFAULT,
+};
+
 //-----------------------------------------------------------------------------
 // A class  representing the asynchronous load of a data stream from an URL.
 //
 // The lifetime of an instance of this class is completely controlled by the
 // consumer, and the instance is not required to live on the heap or be
 // allocated in any special way.  It is also valid to delete an URLRequest
 // object during the handling of a callback to its delegate.  Of course, once
 // the URLRequest is deleted, no further callbacks to its delegate will occur.
 //
 // NOTE: All usage of all instances of this class should be on the same thread.
@@ skipping 218 matching lines @@
 
   // The referrer policy to apply when updating the referrer during redirects.
   // The referrer policy may only be changed before Start() is called.
   ReferrerPolicy referrer_policy() const { return referrer_policy_; }
   void set_referrer_policy(ReferrerPolicy referrer_policy);
 
   // Sets the delegate of the request.  This value may be changed at any time,
   // and it is permissible for it to be null.
   void set_delegate(Delegate* delegate);
 
+  // TODO(megjablon): Add comment.

[bengr, 2015/08/25 00:00:02]

Add it.

[megjablon, 2015/08/25 20:29:47]

Done.

+  void set_lofi_state(LoFiState lofi_state);
+
+  LoFiState lofi_state() const { return lofi_state_; }
+
   // Indicates that the request body should be sent using chunked transfer
   // encoding. This method may only be called before Start() is called.
   void EnableChunkedUpload();
 
   // Appends the given bytes to the request's upload data to be sent
   // immediately via chunked transfer encoding. When all data has been added,
   // set |is_last_chunk| to true to indicate the end of upload data.  All chunks
   // but the last must have |bytes_len| > 0.
   //
   // This method may be called only after calling EnableChunkedUpload().
@@ skipping 511 matching lines @@
   LoadTimingInfo load_timing_info_;
 
   // Keeps track of whether or not OnBeforeNetworkStart has been called yet.
   bool notified_before_network_start_;
 
   // The proxy server used for this request, if any.
   HostPortPair proxy_server_;
 
   scoped_ptr<const base::debug::StackTrace> stack_trace_;
 
+  // TODO(megjablon): Add comment

[bengr, 2015/08/25 00:00:02]

Add it.

[megjablon, 2015/08/25 20:29:47]

Done.

+  LoFiState lofi_state_;
+
   DISALLOW_COPY_AND_ASSIGN(URLRequest);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_H_