Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1310733002: Remove arbitrary references to ChromeShell in comments. (Closed)

Created:
5 years, 4 months ago by newt (away)
Modified:
5 years, 4 months ago
CC:
chromium-reviews, samuong+watch_chromium.org, android-webview-reviews_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, auto-bisect-reviews_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove arbitrary references to ChromeShell in comments. Since ChromeShell is going away, we shouldn't reference it in examples in comments. This updates those comments to use something else as an example. Also, removing these references makes it easier to grep for the real remaining uses of ChromeShell in the codebase. BUG=510220 Committed: https://crrev.com/309af8fba631f827583b3c4f19acf7b3b50c6363 Cr-Commit-Position: refs/heads/master@{#345452}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -23 lines) Patch
M android_webview/android_webview_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M base/android/java/src/org/chromium/base/CommandLine.java View 1 chunk +1 line, -1 line 0 comments Download
M build/android/gyp/apk_install.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/gyp/util/build_device.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/jinja_template.gypi View 2 chunks +6 lines, -6 lines 0 comments Download
M build/config/android/rules.gni View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/chromedriver/test/webview_shell/BUILD.gn View 1 chunk +0 lines, -1 line 1 comment Download
M tools/auto_bisect/bisect_perf_regression.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/mb/mb.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
newt (away)
PTAL. It's just a few lines each. boliu: android_webview prasadv: tools/auto_bisect samuong: chrome/test/chromedriver nyquist: base ...
5 years, 4 months ago (2015-08-21 19:33:33 UTC) #2
boliu
rs lgtm
5 years, 4 months ago (2015-08-21 19:55:54 UTC) #3
samuong
chromedriver lgtm We're still using ChromeShell for waterfall testing with ChromeDriver, but we'll be replacing ...
5 years, 4 months ago (2015-08-21 20:04:17 UTC) #4
newt (away)
nyquist and dpranke: ping?
5 years, 4 months ago (2015-08-24 20:48:29 UTC) #5
nyquist
lgtm
5 years, 4 months ago (2015-08-24 21:05:16 UTC) #6
Dirk Pranke
lgtm. Sorry for the delay; was ooo ...
5 years, 4 months ago (2015-08-25 19:29:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310733002/1
5 years, 4 months ago (2015-08-25 20:45:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-25 22:10:26 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 22:11:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/309af8fba631f827583b3c4f19acf7b3b50c6363
Cr-Commit-Position: refs/heads/master@{#345452}

Powered by Google App Engine
This is Rietveld 408576698