Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 1310713002: Moving chrome/browser/chromeos/drive/change_list* into components/drive (Closed)

Created:
5 years, 4 months ago by Łukasz Anforowicz
Modified:
5 years, 4 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, tim+watch_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, zea+watch_chromium.org, tzik, tfarina, maxbogue+watch_chromium.org, nhiroki, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, oshima+watch_chromium.org, blundell+watchlist_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moving chrome/browser/chromeos/drive/change_list* into components/drive Files moved from chrome/browser/chromeos/drive into components/drive: - change_list_loader.cc - change_list_loader.h - change_list_loader_observer.h - change_list_loader_unittest.cc - change_list_processor.cc - change_list_processor.h - change_list_processor_unittest.cc Test steps: 1. Verify that things still build via GYP. $ GYP_DEFINES="use_goma=1 chromeos=1" gclient sync $ ninja -C out/Debug -j 150 chrome unit_tests \ interactive_ui_tests browser_tests drive 2. Verify that things still build via GN. $ gn gen out/Default --args='target_os="chromeos" use_goma=true' $ ninja -C out/Default -j 150 chrome unit_tests \ interactive_ui_tests browser_tests components/drive TEST=Please see "Test steps" above. BUG=257943, 498951 Committed: https://crrev.com/b80bf26365a1bfa10810c5c7d3c8b7014536feab Cr-Commit-Position: refs/heads/master@{#345103}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed paths in components/drive/BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2652 lines) Patch
D chrome/browser/chromeos/drive/change_list_loader.h View 1 chunk +0 lines, -249 lines 0 comments Download
D chrome/browser/chromeos/drive/change_list_loader.cc View 1 chunk +0 lines, -585 lines 0 comments Download
D chrome/browser/chromeos/drive/change_list_loader_observer.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/chromeos/drive/change_list_loader_unittest.cc View 1 chunk +0 lines, -401 lines 0 comments Download
D chrome/browser/chromeos/drive/change_list_processor.h View 1 chunk +0 lines, -171 lines 0 comments Download
D chrome/browser/chromeos/drive/change_list_processor.cc View 1 chunk +0 lines, -502 lines 0 comments Download
D chrome/browser/chromeos/drive/change_list_processor_unittest.cc View 1 chunk +0 lines, -658 lines 0 comments Download
M chrome/browser/chromeos/drive/directory_loader.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/directory_loader_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/operation_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/search_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/search_operation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_revert_performer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/sync_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 4 chunks +4 lines, -4 lines 0 comments Download
M components/drive.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M components/drive/BUILD.gn View 1 1 chunk +5 lines, -0 lines 0 comments Download
M components/drive/DEPS View 1 chunk +3 lines, -1 line 0 comments Download
A + components/drive/change_list_loader.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/drive/change_list_loader.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/drive/change_list_loader_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/drive/change_list_loader_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/drive/change_list_processor.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/drive/change_list_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/drive/change_list_processor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Łukasz Anforowicz
Ryo, could you please take a look?
5 years, 4 months ago (2015-08-21 19:12:37 UTC) #2
hashimoto
lgtm assuming GN gets fixed. https://codereview.chromium.org/1310713002/diff/1/components/drive/BUILD.gn File components/drive/BUILD.gn (right): https://codereview.chromium.org/1310713002/diff/1/components/drive/BUILD.gn#newcode9 components/drive/BUILD.gn:9: "drive/change_list_loader.cc", No need to ...
5 years, 4 months ago (2015-08-24 05:44:38 UTC) #3
Łukasz Anforowicz
https://codereview.chromium.org/1310713002/diff/1/components/drive/BUILD.gn File components/drive/BUILD.gn (right): https://codereview.chromium.org/1310713002/diff/1/components/drive/BUILD.gn#newcode9 components/drive/BUILD.gn:9: "drive/change_list_loader.cc", On 2015/08/24 05:44:37, hashimoto wrote: > No need ...
5 years, 4 months ago (2015-08-24 16:27:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310713002/20001
5 years, 4 months ago (2015-08-24 16:28:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-24 17:04:41 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 17:05:25 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b80bf26365a1bfa10810c5c7d3c8b7014536feab
Cr-Commit-Position: refs/heads/master@{#345103}

Powered by Google App Engine
This is Rietveld 408576698