Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1310653004: X87: [es6] Initial steps towards a correct implementation of IsCallable. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [es6] Initial steps towards a correct implementation of IsCallable. port 8a378f46d52ce64578c71313ed76a67592fbf63c (r30552) original commit message: This turns the has_instance_call_handler bit on Map into an is_callable bit, that matches the spec definition of IsCallable (i.e. instances have [[Call]] internal methods). Also fix the typeof operator to properly say "function" for everything that is callable. Also remove the (unused) premature %_GetPrototype optimization from Crankshaft, which just complicated the Map bit swap. BUG= Committed: https://crrev.com/57d16cf417b7301e9d45417fcae81d00588f74ac Cr-Commit-Position: refs/heads/master@{#30609}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +11 lines, -11 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-09-06 10:20:46 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-07 07:17:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310653004/1
5 years, 3 months ago (2015-09-07 07:18:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-07 08:00:44 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 08:01:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57d16cf417b7301e9d45417fcae81d00588f74ac
Cr-Commit-Position: refs/heads/master@{#30609}

Powered by Google App Engine
This is Rietveld 408576698