Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1437)

Issue 1310653003: [DevTools] Fix one more backwards compatibility breakage. (Closed)

Created:
5 years, 4 months ago by dgozman
Modified:
5 years, 4 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Fix one more backwards compatibility breakage. With recent changes, it's dangerous to inject /deep/ selectors to the page, as they get high priority. This patch stops injecting backwards compatilibity code to the all-new frontned. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201106

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/devtools/front_end/devtools.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dgozman
Take a look please.
5 years, 4 months ago (2015-08-25 00:49:09 UTC) #2
pfeldman
lgtm
5 years, 4 months ago (2015-08-25 00:53:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310653003/1
5 years, 4 months ago (2015-08-25 00:54:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103494)
5 years, 4 months ago (2015-08-25 02:05:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310653003/1
5 years, 4 months ago (2015-08-25 05:11:40 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 05:44:31 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201106

Powered by Google App Engine
This is Rietveld 408576698