Make classes and structures in core/events and core/fetch fast-allocated.

Make classes and structures in core/events and core/fetch fast-allocated.

Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201203

[tasak, 2015-08-24 10:51:24]

Patchset #1 (id:1) has been deleted

[tasak, 2015-08-24 10:51:33]

Patchset #1 (id:20001) has been deleted

[tasak, 2015-08-24 10:51:50]

tasak@google.com changed reviewers:
+ haraken@chromium.org

[tasak, 2015-08-24 10:51:51]

Would you review this CL?

[haraken, 2015-08-24 10:59:13]

https://codereview.chromium.org/1310643003/diff/40001/Source/core/events/Even...
File Source/core/events/EventFactory.h (right):

https://codereview.chromium.org/1310643003/diff/40001/Source/core/events/Even...
Source/core/events/EventFactory.h:48: WTF_MAKE_FAST_ALLOCATED(EventFactory);

Our plan is to add the macro to the most parent class, isn't it?

https://codereview.chromium.org/1310643003/diff/40001/Source/core/fetch/Docum...
File Source/core/fetch/DocumentResourceReference.h (right):

https://codereview.chromium.org/1310643003/diff/40001/Source/core/fetch/Docum...
Source/core/fetch/DocumentResourceReference.h:35:
WTF_MAKE_FAST_ALLOCATED(DocumentResourceReference);

Our plan is to add the macro only to the most parent class, isn't it?

[tasak, 2015-08-25 03:54:41]

Thank you for review.

https://codereview.chromium.org/1310643003/diff/40001/Source/core/events/Even...
File Source/core/events/EventFactory.h (right):

https://codereview.chromium.org/1310643003/diff/40001/Source/core/events/Even...
Source/core/events/EventFactory.h:48: WTF_MAKE_FAST_ALLOCATED(EventFactory);
On 2015/08/24 10:59:12, haraken wrote:
> 
> Our plan is to add the macro to the most parent class, isn't it?

Done.

https://codereview.chromium.org/1310643003/diff/40001/Source/core/fetch/Docum...
File Source/core/fetch/DocumentResourceReference.h (right):

https://codereview.chromium.org/1310643003/diff/40001/Source/core/fetch/Docum...
Source/core/fetch/DocumentResourceReference.h:35:
WTF_MAKE_FAST_ALLOCATED(DocumentResourceReference);
On 2015/08/24 10:59:12, haraken wrote:
> 
> Our plan is to add the macro only to the most parent class, isn't it?

I think, "if possible, we will add the macro to the most parent class."
We should consider multiple inheritance. 
FYI:
class SVGUseElement final : public SVGGraphicsElement,
                            public SVGURIReference,
                            public DocumentResourceClient

SVGUseElement=> SVGraphicsElement => SVGElement => Element => ContainerNode =>
Node (Node has operator new)

If we see  WILL_BE_USING_GARBAGE_COLLECTED_MIXIN",  we should be careful.

[haraken, 2015-08-25 03:56:20]

On 2015/08/25 03:54:41, tasak wrote:
> Thank you for review.
> 
>
https://codereview.chromium.org/1310643003/diff/40001/Source/core/events/Even...
> File Source/core/events/EventFactory.h (right):
> 
>
https://codereview.chromium.org/1310643003/diff/40001/Source/core/events/Even...
> Source/core/events/EventFactory.h:48: WTF_MAKE_FAST_ALLOCATED(EventFactory);
> On 2015/08/24 10:59:12, haraken wrote:
> > 
> > Our plan is to add the macro to the most parent class, isn't it?
> 
> Done.
> 
>
https://codereview.chromium.org/1310643003/diff/40001/Source/core/fetch/Docum...
> File Source/core/fetch/DocumentResourceReference.h (right):
> 
>
https://codereview.chromium.org/1310643003/diff/40001/Source/core/fetch/Docum...
> Source/core/fetch/DocumentResourceReference.h:35:
> WTF_MAKE_FAST_ALLOCATED(DocumentResourceReference);
> On 2015/08/24 10:59:12, haraken wrote:
> > 
> > Our plan is to add the macro only to the most parent class, isn't it?
> 
> I think, "if possible, we will add the macro to the most parent class."
> We should consider multiple inheritance. 
> FYI:
> class SVGUseElement final : public SVGGraphicsElement,
>                             public SVGURIReference,
>                             public DocumentResourceClient
> 
> SVGUseElement=> SVGraphicsElement => SVGElement => Element => ContainerNode =>
> Node (Node has operator new)
> 
> If we see  WILL_BE_USING_GARBAGE_COLLECTED_MIXIN",  we should be careful.

ok, LGTM

[tasak, 2015-08-25 09:12:32]

The CQ bit was checked by tasak@google.com

[commit-bot: I haz the power, 2015-08-25 09:12:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1310643003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1310643003/60001

[commit-bot: I haz the power, 2015-08-25 10:16:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-25 10:16:12]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tasak, 2015-08-26 03:55:46]

The CQ bit was checked by tasak@google.com

[commit-bot: I haz the power, 2015-08-26 03:55:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1310643003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1310643003/60001

[commit-bot: I haz the power, 2015-08-26 06:16:43]

Committed patchset #2 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201203

[Yuta Kitamura, 2015-10-26 08:15:53]

yutak@chromium.org changed reviewers:
+ yutak@chromium.org

[Yuta Kitamura, 2015-10-26 08:15:54]

tasak: I've come across with this change and I have a question.

https://codereview.chromium.org/1310643003/diff/60001/Source/core/events/Even...
File Source/core/events/EventTarget.h (right):

https://codereview.chromium.org/1310643003/diff/60001/Source/core/events/Even...
Source/core/events/EventTarget.h:54: ALLOW_ONLY_INLINE_ALLOCATION();
Is this needed?

FiringEventIterator only contains off-heap objects, so having
ALLOW_ONLY_INLINE_ALLOCATION() here seems meritless.

[tasak, 2015-10-26 08:19:01]

https://codereview.chromium.org/1310643003/diff/60001/Source/core/events/Even...
File Source/core/events/EventTarget.h (right):

https://codereview.chromium.org/1310643003/diff/60001/Source/core/events/Even...
Source/core/events/EventTarget.h:54: ALLOW_ONLY_INLINE_ALLOCATION();
On 2015/10/26 08:15:54, Yuta Kitamura wrote:
> Is this needed?
> 
> FiringEventIterator only contains off-heap objects, so having
> ALLOW_ONLY_INLINE_ALLOCATION() here seems meritless.

I added this to ensure that no one invokes FiringEventIterator's new / delete.