Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1310633004: Read all integer op parameters using a signed integer type. (Closed)

Created:
5 years, 3 months ago by pcc1
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Read all integer op parameters using a signed integer type. The code was previously reading unsigned integers by performing an invalid cast of Operator1<intNN_t> objects to Operator1<uintNN_t> and reading the integer directly. To fix the invalid cast, we cast to the correct type and static_cast the integer to uintNN_t, which is a no-op on every reasonable target. Cleanup for cfi_vptr=1; see https://www.chromium.org/developers/testing/control-flow-integrity BUG=chromium:457523 R=bmeurer@chromium.org LOG=N Committed: https://crrev.com/e67f5cf4b8211a2d12e1ce50ab1ee5ec0d00c3ce Cr-Commit-Position: refs/heads/master@{#30499}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M src/compiler/node-matchers.h View 2 chunks +14 lines, -2 lines 0 comments Download
M src/compiler/representation-change.h View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
pcc1
5 years, 3 months ago (2015-09-01 03:59:45 UTC) #1
Benedikt Meurer
LGTM
5 years, 3 months ago (2015-09-01 04:03:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310633004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310633004/1
5 years, 3 months ago (2015-09-01 04:16:35 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_TIMED_OUT, no build URL)
5 years, 3 months ago (2015-09-01 06:16:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310633004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310633004/1
5 years, 3 months ago (2015-09-01 08:50:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 09:11:01 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 09:11:18 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e67f5cf4b8211a2d12e1ce50ab1ee5ec0d00c3ce
Cr-Commit-Position: refs/heads/master@{#30499}

Powered by Google App Engine
This is Rietveld 408576698