Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2791)

Unified Diff: core/src/fxcodec/codec/codec_int.h

Issue 1310603006: Cleanup dead code in CPDF_DIBSource::LoadJpxBitmap() and friends. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: no pass by ref, use override, use unique_ptr, remove dead param Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/src/fxcodec/codec/codec_int.h
diff --git a/core/src/fxcodec/codec/codec_int.h b/core/src/fxcodec/codec/codec_int.h
index 4bcdeed7ad1f8e92a9465f8d8cb8497c5cf9948e..585e09635f3ec7aa1f4278e68b1d255c6b8225f5 100644
--- a/core/src/fxcodec/codec/codec_int.h
+++ b/core/src/fxcodec/codec/codec_int.h
@@ -247,20 +247,22 @@ class CCodec_IccModule : public ICodec_IccModule {
class CCodec_JpxModule : public ICodec_JpxModule {
public:
CCodec_JpxModule();
+ ~CCodec_JpxModule() override;
+
+ // ICodec_JpxModule:
void* CreateDecoder(const uint8_t* src_buf,
FX_DWORD src_size,
- FX_BOOL useColorSpace = FALSE);
+ FX_BOOL useColorSpace) override;
void GetImageInfo(void* ctx,
- FX_DWORD& width,
- FX_DWORD& height,
- FX_DWORD& codestream_nComps,
- FX_DWORD& output_nComps);
+ FX_DWORD* width,
+ FX_DWORD* height,
+ FX_DWORD* codestream_nComps,
+ FX_DWORD* output_nComps) override;
FX_BOOL Decode(void* ctx,
uint8_t* dest_data,
int pitch,
- FX_BOOL bTranslateColor,
- uint8_t* offsets);
- void DestroyDecoder(void* ctx);
+ uint8_t* offsets) override;
+ void DestroyDecoder(void* ctx) override;
};
class CPDF_Jbig2Interface : public CJBig2_Module {

Powered by Google App Engine
This is Rietveld 408576698